OpenStack Destroy Cluster Support

[hardys]

Adds initial destroy support for OpenStack, currently this only considers Server resources, network resources will be considered either via an update to this PR or follow-up PR's, whichever is preferable.

[hardys]

Ok I added the vendored dependencies, and rebased on the latest logger changes - this is now working well for me to delete the servers.

Do we want to land this and incrementally add the remaining resources (network/subnet/port/router), or should I keep pushing to this one PR?

[hardys]

Also I removed WIP as this now works, albeit only for the server resources.

[wking]

nit: This is missing trailing period.

Some of your other godocs comments are as well. Obviously not the end of the world, but should be easy to fix ;).

And we probably have a number of godocs in master with the same issue; PRs welcome :).

[hardys]

Ah thanks, I'll go through and check - is there a way to build the godocs locally so I can check the format before pushing?

[wking]

Ah thanks, I'll go through and check - is there a way to build the godocs locally so I can check the format before pushing?

$ godoc ./pkg/destroy
PACKAGE DOCUMENTATION

package destroy
    import "./pkg/destroy"

    Package destroy contains tools for destroying clusters based on their
    metadata.

VARIABLES

var Registry = make(map[string]NewFunc)
    Registry maps ClusterMetadata.Platform() to per-platform Destroyer
    creators.

TYPES

type Destroyer interface {
    Run() error
}
    Destroyer allows multiple implementations of destroy for different
    platforms.

func New(logger logrus.FieldLogger, rootDir string) (Destroyer, error)
    New returns a Destroyer based on `metadata.json` in `rootDir`.

func NewAWS(logger logrus.FieldLogger, metadata *types.ClusterMetadata) (Destroyer, error)
    NewAWS returns an AWS destroyer from ClusterMetadata.

type NewFunc func(logger logrus.FieldLogger, metadata *types.ClusterMetadata) (Destroyer, error)
    NewFunc is an interface for creating platform-specific destroyers.

SUBDIRECTORIES

	libvirt

[hardys]

Note I spent some time today looking at adding tags support for the network resources - unfortunately neither gophercloud or terraform-provider-openstack yet support tags for neutron resources, so looks like I'll have to add those before I can make progress, unless anyone has other suggestions on how we might identify the resources for removal?

[russellb]

Can we abuse the resource names as a way to tag them for removal?

[hardys]

Can we abuse the resource names as a way to tag them for removal?

Yeah I guess so, and the libvirt destroy code does that (looks for a prefix), the names would end up pretty ugly though (particularly since the installer isn't idempotent so it could easily reuse a cluster name on each run creating duplicate resources, sigh).

I did look at gophercloud today and writing the tags looks fairly simple ref gophercloud/gophercloud#1259 (WIP)

[flaper87]

(it won't succeed but FYI)

/test e2e-openstack

[hardys]

Ok I'll mark this WIP although the top server commit could potentially land now - the network patches will all depend on terraform-provider-openstack changes that are under review ref https://github.com/terraform-providers/terraform-provider-openstack/issues/453

If anyone wants to help test you can pull the staged tree with all commits at https://github.com/hardys/terraform-provider-openstack/commits/neutron_tags_wip

[hardys]

Note this was blocked on gophercloud patches (all now landed and included in the vendored files in the commits I just pushed), and terraform-provider-openstack patches (under review as mentioned).

I've rebased this and the server/port patches work for me, so I'll go ahead and push support for the other resources so hopefully this will be in good shape when the terraform-provider-openstack patches merge (hopefully next week but we'll see how it goes).

[hardys]

@flaper87 @tomassedovic as discussed I rebased this on the latest #588 and squashed to two commits, the vendor additions for gophercloud and the destroy support itself.

You can test it by deploying as normal, then doing something like:

./bin/openshift-install --log-level=debug --dir rhcos destroy cluster

[hardys]

@flaper87 @tomassedovic as discussed I rebased this on the latest #588 and squashed to two commits, the vendor additions for gophercloud and the destroy support itself.

You can test it by deploying as normal, then doing something like:

./bin/openshift-install --log-level=debug --dir rhcos destroy cluster

[tomassedovic]

I don't see this package anywhere (and my build fails because of that). Is it possible you've left it out in the squash/rebase?

[hardys]

@tomassedovic oops, yes you're right, the new package got lost due to the most recent rebase, I'll re-add it and rebase again now #588 landed, thanks for spotting it!

[hardys]

Marking WIP again since I need to address the rebase issue and we're still blocked on a new release of terraform-provider-openstack, hopefully that will happen this week

[openshift-ci-robot]

@hardys: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	18abe065cca88801b277965208ec328e9905a715	link	/test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hardys]

https://github.com/terraform-providers/terraform-provider-openstack/releases/tag/v1.12.0 has been released so I'll adjust the commit message and remove the WIP

[flaper87]

/lgtm

[flaper87]

/hold cancel
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [flaper87,hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flaper87]

/ok-to-test