Skip to content

Bug 1710981: Default AWS instance type to 'm5' #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 8, 2020
Merged

Bug 1710981: Default AWS instance type to 'm5' #3853

openshift-merge-robot merged 1 commit into from
Jul 8, 2020

Conversation

@mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Jul 7, 2020 •
edited by wking
Loading

Changes default AWS instance type from m4 to m5.

Fixes #2919.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Jul 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2020

@mtnbikenc: This pull request references Bugzilla bug 1710981, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[WIP] Bug 1710981: Default AWS instance type to 'm5'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 7, 2020
mtnbikenc
mtnbikenc commented Jul 7, 2020
View reviewed changes
pkg/types/aws/defaults/platform.go Outdated
Copy link
Member Author

@mtnbikenc mtnbikenc Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya Should we just rip out all the logic for having different defaults for different regions or keep the logic and structure in case we need to implement something similar in the future?

Copy link
Contributor

@abhinavdahiya abhinavdahiya Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should remove the overrides, but keep the mechanism in place.

Copy link
Member

@wking wking Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to keep some overrides for regions/zones that lack m5 support, right?

Copy link
Member

@wking wking Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, I'm stale after the removal of platformtests/ (which I've just filed #3856 to wrap up). I'm not clear on why we would need/want the ability to set overrides if we trust the dynamic APIs we've used since #3051.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2020

@mtnbikenc: This pull request references Bugzilla bug 1710981, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[WIP] Bug 1710981: Default AWS instance type to 'm5'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2020

@mtnbikenc: This pull request references Bugzilla bug 1710981, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[WIP] Bug 1710981: Default AWS instance type to 'm5'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc changed the title [WIP] Bug 1710981: Default AWS instance type to 'm5' Bug 1710981: Default AWS instance type to 'm5' Jul 8, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2020 •
edited
Loading

@mtnbikenc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 51f66d6 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jul 8, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit efd97ce into openshift:master Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2020

@mtnbikenc: All pull requests linked via external trackers have merged: openshift/installer#3853. Bugzilla bug 1710981 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1710981: Default AWS instance type to 'm5'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the fix-1710981 branch July 8, 2020 17:19
@sjenning sjenning mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

+1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws: Use modern instance types by default

5 participants

@mtnbikenc @openshift-ci-robot @abhinavdahiya @wking @openshift-merge-robot