Skip to content

Render openshift-cluster-kube-scheduler-operator assets #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 4, 2018
Merged

Render openshift-cluster-kube-scheduler-operator assets #381

openshift-merge-robot merged 1 commit into from
Oct 4, 2018

Conversation

@aveshagarwal
Copy link
Contributor

@aveshagarwal aveshagarwal commented Oct 1, 2018

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2018
@aveshagarwal aveshagarwal force-pushed the master-cluster-kube-scheduler-operator branch from dcc71e6 to 6d5a5ee Compare October 1, 2018 13:50
@aveshagarwal aveshagarwal changed the title Render openshift-cluster-kube-scheduler-operator assests Render openshift-cluster-kube-scheduler-operator assets Oct 1, 2018
@aveshagarwal aveshagarwal force-pushed the master-cluster-kube-scheduler-operator branch from 6d5a5ee to 8ba9d06 Compare October 1, 2018 13:52
@abhinavdahiya abhinavdahiya mentioned this pull request Oct 3, 2018
Merged
@aveshagarwal aveshagarwal force-pushed the master-cluster-kube-scheduler-operator branch from 8ba9d06 to 44224f1 Compare October 3, 2018 20:48
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2018
@aveshagarwal
Copy link
Contributor Author

aveshagarwal commented Oct 3, 2018

@abhinavdahiya updated PTAL.

abhinavdahiya
abhinavdahiya reviewed Oct 3, 2018
View reviewed changes
pkg/asset/ignition/bootstrap/bootstrap.go Outdated
Copy link
Contributor

@abhinavdahiya abhinavdahiya Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop this.

@aveshagarwal aveshagarwal force-pushed the master-cluster-kube-scheduler-operator branch from 44224f1 to c5e2ef8 Compare October 3, 2018 22:52
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2018
@aveshagarwal
Copy link
Contributor Author

aveshagarwal commented Oct 3, 2018

@abhinavdahiya fixed as per your comment, PTAL.

@wking
Copy link
Member

wking commented Oct 3, 2018

e2e:


• Failure in Spec Setup (BeforeEach) [4.551 seconds]
[sig-storage] Secrets
/tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s] [BeforeEach]
  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684

  Oct  3 23:16:13.437: the server is currently unable to handle the request (get securitycontextconstraints.security.openshift.io privileged)

I dunno what that's about, but I also saw it over here.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 4, 2018

@aveshagarwal #322 was merged; can you rebase this.

@aveshagarwal aveshagarwal force-pushed the master-cluster-kube-scheduler-operator branch from c5e2ef8 to 99b79fa Compare October 4, 2018 21:34
@aveshagarwal
Copy link
Contributor Author

aveshagarwal commented Oct 4, 2018

@aveshagarwal #322 was merged; can you rebase this.

done.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 4, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, aveshagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@openshift-merge-robot openshift-merge-robot merged commit 3926168 into openshift:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@steveej steveej Awaiting requested review from steveej

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aveshagarwal @wking @abhinavdahiya @openshift-ci-robot @openshift-merge-robot