installer/pkg/copy: Factor out Copy into its own package #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
needs-ok-to-test
Member
Author
|
Hold off on this one, there's another |
wking
force-pushed
the
copy-target-write-only
branch
from
037af30 to
a3976a2
Compare
openshift-ci-robot
added
size/L
Member
Author
Ok, I've pushed 037af304 -> 59829963, creating a new |
wking
force-pushed
the
copy-target-write-only
branch
from
a3976a2 to
5982996
Compare
wking
changed the title
Contributor
Contributor
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
Contributor
|
/lgtm |
Member
|
lgtm |
openshift-bot
added
the
needs-rebase
This code is descended from terraformPrepareStep, which landed in 1b4bb62 (Cli tool, 2018-02-05, coreos/tectonic-installer#2806). The workspace version was factored out into copyFile in 2b82fbe (installer: Integrate multistep cli with configuration, 2018-02-16, coreos/tectonic-installer#2960). The config-generator version was copy/pasted (or independently developed?) in 1d54899 (installer/pkg/config-generator/tls: generate root CA's with go, 2018-06-28, coreos/tectonic-installer#3316). This commit DRYs that up by pulling the duplicate code out into a shared package. I've also changed O_RDWR to O_WRONLY. The O_RDWR is originally from 1b4bb62, but we do not require the ability to read from the target file. Also add a unit test to exercise this code.
wking
force-pushed
the
copy-target-write-only
branch
from
5982996 to
9abf7a3
Compare
openshift-bot
removed
the
needs-rebase
Member
Author
Not sure why this just came in now, it looks like the issues were context conflicts with #42, which landed Friday. Anyway, rebased with onto master with 5982996 -> 9abf7a3. |
Contributor
|
/lgtm |
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
O_RDWRis originally from 1b4bb62 (coreos/tectonic-installer#2806), but we do not require the ability to read from the target file.Also add a unit test to exercise this code.