userprovided: change AskOne to Ask as it doesn't run Transform #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/AlecAivazis/survey/blob/f30c5d1830c892f533140f29a1de89141dc217f5/survey.go#L88-L95 ```go func AskOne(p Prompt, response interface{}, v Validator, opts ...AskOpt) error { err := Ask([]*Question{{Prompt: p, Validate: v}}, response, opts...) if err != nil { return err } return nil } ``` AskOne was not passing Transform. This would cause error reading region for aws ```console FATA[0023] failed to generate asset: failed to generate asset "Machine API Operator": failed to lookup RHCOS AMI: InvalidEndpointURL: invalid endpoint uri caused by: parse https://ec2.us-east-1 (N. Virginia).amazonaws.com/: invalid character " " in host name ```
openshift-ci-robot
added
approved
Member
|
/lgtm Cross linking the previous Tranfsorm discussion. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
|
/hold Wait on #379. |
openshift-ci-robot
added
the
do-not-merge/hold
Member
|
#379 merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/AlecAivazis/survey/blob/f30c5d1830c892f533140f29a1de89141dc217f5/survey.go#L88-L95
AskOne was not passing Transform. This would cause error reading region for aws
/cc @wking