*: improve logging messages #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XXL
Contributor
|
/approve |
wking
reviewed
Sep 29, 2018
Member
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
The only thing I feel really strongly about is the Apply error handling, which is largely orthogonal, so I'm fine punting to a seperate PR. Take what you want from the other suggestions and I'll /lgtm.
wking
reviewed
Oct 2, 2018
wking
reviewed
Oct 2, 2018
No changes to `glide.yaml`; just running an update.
This bumps github.com/sirupsen/logrus to v1.1.0, which provides the DisableLevelTruncation option in the text formatter.
This slightly improves some of the logging messages and hides the
Terraform output by default (it can still be enabled by setting the log
level to debug). Installing a cluster with libvirt looks like the
following:
INFO Fetching OS image...
INFO Using Terraform to create cluster...
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly improves some of the logging messages and hides the
Terraform output by default (it can still be enabled by setting the log
level to debug). Installing a cluster with libvirt looks like the
following: