Skip to content

Bug 1847172 vSphere docs: update UPI docs for folder name #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 15, 2020
Merged

Bug 1847172 vSphere docs: update UPI docs for folder name #3738

openshift-merge-robot merged 1 commit into from
Jun 15, 2020

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Jun 10, 2020

vSphere UPI docs should take into account that the cloud-provider-config
manifest specifies the folder with the name of cluster id.

@patrickdillon
vSphere docs: update UPI docs for folder name
1408015 
vSphere UPI docs should take into account that the cloud-provider-config
manifest specifies the folder with the name of cluster id.
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jun 10, 2020

cc @jcpowermac

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jun 10, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 10, 2020

@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jun 10, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
abhinavdahiya
abhinavdahiya reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit f76e4ae into openshift:master Jun 15, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 15, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 15, 2020

@patrickdillon: new pull request created: #3758

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jun 15, 2020

/retitle Bug 1847172 vSphere docs: update UPI docs for folder name

@openshift-ci-robot openshift-ci-robot changed the title vSphere docs: update UPI docs for folder name Bug 1847172 vSphere docs: update UPI docs for folder name Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrickdillon @openshift-cherrypick-robot @abhinavdahiya @openshift-ci-robot @openshift-merge-robot