Skip to content

cmd/openshift-install/create: Mention 'wait-for' when install-complete fails #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

cmd/openshift-install/create: Mention 'wait-for' when install-complete fails #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/openshift-install/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ var (
if err2 := logClusterOperatorConditions(ctx, config); err2 != nil {
logrus.Error("Attempted to gather ClusterOperator status after installation failure: ", err2)
}
logrus.Info("Use the following command if you want to wait longer for install completion:")
logrus.Info("openshift-install wait-for install-complete --help")
Copy link
Member

@stbenjam stbenjam Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either here or in the help (which only says "Wait until the cluster is ready"), what do you think of explaining why someone might want to wait longer?

Copy link
Member Author

@wking wking Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that decision is up to the user, and depends on their feelings vs. the ClusterOperator and ClusterVersion conditions we report immediately before and after these new lines. What would you add?

logrus.Fatal(err)
}
timer.StopTimer(timer.TotalTimeElapsed)
Expand Down
2 changes: 1 addition & 1 deletion cmd/openshift-install/waitfor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func newWaitForBootstrapCompleteCmd() *cobra.Command {
logrus.Error("Attempted to gather ClusterOperator status after wait failure: ", err2)
}

logrus.Info("Use the following commands to gather logs from the cluster")
logrus.Info("Use the following command to gather logs from the cluster:")
logrus.Info("openshift-install gather bootstrap --help")
logrus.Fatal(err)
}
Expand Down