installer/pkg/workflow: Change public 'Step' to private 'step' #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
needs-ok-to-test
Contributor
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
Contributor
|
/lgtm |
openshift-bot
added
the
needs-rebase
The *metadata argument is private, and Workflow.steps is private, so there's not much use in having a public Step type.
wking
force-pushed
the
private-workflow-step
branch
from
57cd889 to
e7558d2
Compare
openshift-bot
removed
the
needs-rebase
openshift-ci-robot
added
size/S
Member
Author
Contributor
|
@wking Thanks for the cleanup! |
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Read images required for metal3 deployment from configmap
mkumatag
pushed a commit
to mkumatag/installer
that referenced
this pull request
Aug 5, 2021
Signed-off-by: Christy Norman <[email protected]>
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
Signed-off-by: Christy Norman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
*metadataargument is private, andWorkflow.stepsis private, so there's not much use in having a publicSteptype.