Bug 1838032: Better docs for using custom subnets #3647

iamemilio · 2020-05-22T20:26:03Z

This beefs up the openstack docs for installing with a custom subnet.

/cc @pierreprinetti @maxwelldb @morenod
/label platform/openstack

openshift-ci-robot · 2020-05-26T01:03:47Z

@iamemilio: This pull request references Bugzilla bug 1838032, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1838032: Better docs for using custom subnets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-05-26T06:55:34Z

docs/user/openstack/customization.md

The user-provided subnet needs to have a DHCP server. This will likely always be the case, but better be explicit about the requirement.

Also, we should explain how to avoid potential IP address conflicts with the API and Ingress VIPs. These IP should be picked outside of the DHCP range and passed to the installer via the apiVIP and ingressVIP options. It would actually be better if we could let the DHCP assign the VIPs on the ports.

How would we have dhcp assign the ports? I looked into allowing the ports to be set dynamically in the installer and the way things are right now, it is not doable.

Using the CLI, by specifying --fixed-ip "subnet=<my-subnet>", it's possible to let the DHCP assign an IP to the port:

$ openstack port create --network mandre-krc6g-openshift --security-group mandre-krc6g-worker --fixed-ip "subnet=mandre-krc6g-nodes" --tag openshiftClusterID="mandre-krc6g" "mandre-krc6g-test-port" $ openstack port show mandre-krc6g-test-port -f value -c fixed_ips [{'subnet_id': 'c72ac7d7-2f46-4698-92ad-22458089de7d', 'ip_address': '10.0.128.34'}]

the installer doesn't let you pass a port, it only lets you pass it an IP address to make a port from. I am proposing changing it to allow you to pass the ports directly here though: openshift/enhancements#342

Well, the installer creates the port. It's the same thing. I showed how it worked with the CLI. In terraform, you'd have to pass a fixed_ip stuct with a subnet_id for the port creation.

https://www.terraform.io/docs/providers/openstack/r/networking_port_v2.html#fixed_ip

Fedosin · 2020-05-27T15:26:09Z

/lgtm

iamemilio · 2020-05-27T15:28:56Z

/hold until I close all the comments

iamemilio · 2020-05-27T21:15:16Z

/hold cancel

mandre · 2020-05-28T08:01:12Z

docs/user/openstack/customization.md

Seems like this addition has nothing to do here :)

mandre · 2020-05-28T08:06:17Z

docs/user/openstack/customization.md

I'd like a comment somewhere saying that apiVIP and ingressVIP should be picked outside of the DHCP allocation range in order to avoid any IP address conflicts.

hmm yeah that is wise, I will add that

maxwelldb · 2020-05-29T21:20:24Z

docs/user/openstack/customization.md

@iamemilio "machiensSubnet" -> "machinesSubnet"

mandre · 2020-06-02T06:48:55Z

docs/user/openstack/customization.md

s/tage/tag/
Do we track the support (or lack of) custom subnets and provider networks somewhere? Not asking to put the link in the doc.

I am not sure, but this has come up a few times as a common misunderstanding. If not here, we should make a note of it somewhere at least

mandre · 2020-06-05T13:18:38Z

I personally find it a little too verbose. Not a bit deal, it still provides good information. We can rework the docs later if it's really bothering us.
/lgtm

adduarte · 2020-06-05T20:57:40Z

/lgtm

openshift-ci-robot · 2020-06-06T10:07:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/user/openstack/OWNERS~~ [Fedosin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-06-06T10:11:43Z

@iamemilio: Bugzilla bug 1838032 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 1838032: Better docs for using custom subnets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from maxwelldb, morenod and pierreprinetti May 22, 2020 20:26

openshift-ci-robot added the platform/openstack label May 22, 2020

maxwelldb mentioned this pull request May 24, 2020

Customer-provided networks in ShiftStack installation - OSDOCS openshift/openshift-docs#22186

Merged

iamemilio changed the title ~~Better docs for using custom subnets~~ Bug 1838032: Better docs for using custom subnets May 26, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 26, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 26, 2020

mandre reviewed May 26, 2020

View reviewed changes

openshift-ci-robot assigned Fedosin May 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels May 27, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020

mandre reviewed May 28, 2020

View reviewed changes

iamemilio force-pushed the Enhance_BYO_docs_openstack branch 2 times, most recently from ebfca77 to 6debf76 Compare May 29, 2020 20:13

maxwelldb reviewed May 29, 2020

View reviewed changes

iamemilio force-pushed the Enhance_BYO_docs_openstack branch from 6debf76 to f681266 Compare June 1, 2020 14:37

mandre reviewed Jun 2, 2020

View reviewed changes

Better docs for using custom subnets

fb30018

iamemilio force-pushed the Enhance_BYO_docs_openstack branch from f681266 to fb30018 Compare June 4, 2020 18:46

openshift-ci-robot assigned mandre Jun 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020

openshift-ci-robot assigned adduarte Jun 5, 2020

Fedosin approved these changes Jun 6, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2020

openshift-merge-robot merged commit f206ff1 into openshift:master Jun 6, 2020

Bug 1838032: Better docs for using custom subnets #3647

Bug 1838032: Better docs for using custom subnets #3647

Uh oh!

Conversation

iamemilio commented May 22, 2020

Uh oh!

openshift-ci-robot commented May 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fedosin commented May 27, 2020

Uh oh!

iamemilio commented May 27, 2020

Uh oh!

iamemilio commented May 27, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxwelldb May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandre commented Jun 5, 2020

Uh oh!

adduarte commented Jun 5, 2020

Uh oh!

openshift-ci-robot commented Jun 6, 2020

Uh oh!

openshift-ci-robot commented Jun 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

maxwelldb May 29, 2020 •

edited

Loading