*: Drop Terraform steps #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-bot
added
the
needs-rebase
openshift-ci-robot
added
approved
This removes all of the files which are directly required by bazel.
The installer no longer reads Ignition files or the CA from disk, so these aren't needed.
The installer package is going to be removed. This moves the remaining validation functionality.
wking
force-pushed
the
drop-steps-concept
branch
from
5a3d875 to
24bd835
Compare
This is the last of the old installer code. It's no longer used and can be removed.
After removing the installer code, these dependencies were removed by glide.
These were used by the old installer, which has now been deleted.
Rather than just checking the old directories, we'd might as well test the entire repository. This also updates all of the yaml files, making them more readable, in my opinion.
Now that we've dropped the old installer and only have to support a single Terraform operation at cluster-launch, drop the "step" concept.
wking
force-pushed
the
drop-steps-concept
branch
from
24bd835 to
820502f
Compare
openshift-bot
removed
the
needs-rebase
wking
force-pushed
the
drop-steps-concept
branch
from
820502f to
d08fec3
Compare
Don't unpack modules which are not needed for the target platform. And shuffle our modules around to collect the per-package stuff together. Now that we have a single Terraform step and all the shared asset generation is in Go, we can dispense with the modules/ distinction.
wking
force-pushed
the
drop-steps-concept
branch
from
d08fec3 to
0bec46d
Compare
Member
Author
|
Most of the difference here is #342, but here's $ tree -d
.
├── aws
│ ├── bootstrap
│ ├── iam
│ ├── master
│ ├── route53
│ └── vpc
└── libvirt
├── bootstrap
└── volume
9 directoriesVs. yesterday's master (22f8f5f): $ tree -d
.
├── modules
│ ├── aws
│ │ ├── bootstrap
│ │ ├── iam
│ │ ├── master
│ │ └── vpc
│ ├── bootkube
│ │ └── resources
│ │ └── manifests
│ ├── dns
│ │ └── route53
│ ├── ignition
│ │ └── resources
│ │ ├── files
│ │ └── services
│ ├── libvirt
│ │ ├── bootstrap
│ │ └── volume
│ └── tectonic
│ └── resources
│ └── manifests
│ ├── ingress
│ ├── rbac
│ ├── secrets
│ ├── security
│ └── updater
│ ├── app_versions
│ └── operators
└── steps
└── infra
├── aws
└── libvirt
32 directoriesThat just makes me happy :). |
Contributor
|
This is fantastic. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 28, 2018
We used to use this for passing asset state from the assets step to the infra step. But the new installer performs all asset generation in Go with a single Terraform step (e.g. see df14588, *: Drop Terraform steps, 2018-09-27, openshift#362). So we'll alwayshave var.ignition_bootstrap set and we can just use it directly.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #342; you may want to wait until that lands before reviewing.
Now that we've dropped the old installer and only have to support a single Terraform operation at cluster-launch, drop the "step" concept.