-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bug 1834966: update vSphere UPI docs to remove machinesets #3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834966: update vSphere UPI docs to remove machinesets #3619
Conversation
|
@patrickdillon: An error was encountered adding this pull request to the external tracker bugs for bug 1834966 on the Bugzilla server at https://bugzilla.redhat.com:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.4 |
|
@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/user/vsphere/install_upi.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe truncated find if the items to sure that this is an example as there list might change.. keep the openshift/ machine objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavdahiya Updated but not sure if this is what you had in mind. If not, let me know and I am happy to revise.
To enable infrastructure provisioning in vSphere, the installer now creates machine object and machineset manifests. This commit updates UPI docs to remove those manifests, as the skew between the installer produced manifests and user-provisioned control-plane causes errors.
c18a81e to
ea5e1bf
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@abhinavdahiya: This pull request references Bugzilla bug 1834966, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: All pull requests linked via external trackers have merged: openshift/installer#3619. Bugzilla bug 1834966 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: new pull request created: #3624 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To enable infrastructure provisioning in vSphere, the installer now
creates machine object and machineset manifests. This commit updates
UPI docs to remove those manifests, as the skew between the installer
produced manifests and user-provisioned control-plane causes errors.
cc @jcpowermac