pkg/asset/installconfig: Add OPENSHIFT_INSTALL_PULL_SECRET_PATH #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables are annoying to maintain in ASCII, and lists give us more space to talk about the expected input format, etc.
To make it easier to pass this in when you don't have a shell for: $ OPENSHIFT_INSTALL_SSH_PUB_KEY="$(cat path/to/key)" openshift-install install-config For example, this is useful in CI where we can launch the cluster without hitting a shell at all. And it's also a bit more compact for folks who are reading from files anyway. I've also added a check for "do we only have one choice?". If so, I just pick that value instead of bothering the user when they don't have a decision to make.
openshift-ci-robot
added
size/L
For the same reasons the previous commit added *_PATH support for SSH pubkeys.
wking
force-pushed
the
pull-secret-path-from-env-var
branch
from
a184aa6 to
16e5eb6
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #351; review that first.
For the same reasons #351 added
*_PATHsupport for SSH pubkeys./assign @crawford