Skip to content

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Apr 24, 2020

Using jq will simplify the CI scripts where we currently use awk to parse JSON.

@pierreprinetti pierreprinetti force-pushed the os_dockerfile_jq branch 4 times, most recently from ac508bb to 3bcd37a Compare April 24, 2020 12:28
@pierreprinetti
Copy link
Member Author

/uncc patrickdillon jstuever

@pierreprinetti
Copy link
Member Author

/retitle Bug 1827667: openstack: Add jq to the CI image

@openshift-ci-robot openshift-ci-robot changed the title openstack: Add jq to the CI image Bug 1827667: openstack: Add jq to the CI image Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1827667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1827667: openstack: Add jq to the CI image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 24, 2020
@pierreprinetti pierreprinetti force-pushed the os_dockerfile_jq branch 6 times, most recently from 534e6d9 to 746aa0b Compare April 27, 2020 17:34
@pierreprinetti
Copy link
Member Author

Installing from the Centos7 RDO repository gives the same dependency mismatch than with the stock repositories.

Installing from URL with checksum.

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/test e2e-openstack-upi
just for fun

@mandre
Copy link
Member

mandre commented Apr 28, 2020

Installing from the Centos7 RDO repository gives the same dependency mismatch than with the stock repositories.

Installing from URL with checksum.

It's still trying to install jq from the rhel-server-ose repository:

Error: Package: jq-1.6-2.el7.x86_64 (@rhel-server-ose)

You might need to do:

yum install --setopt=tsflags=nodocs --disablerepo="*" --enablerepo=delorean-master-build-deps -y jq

Using jq will simplify the CI scripts where we currently use `awk` to
parse JSON.
@mandre
Copy link
Member

mandre commented Apr 29, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-upi 746aa0b00b50c14f84ee13027eba769149ff27c8 link /test e2e-openstack-upi
ci/prow/e2e-ovirt a35d912 link /test e2e-ovirt
ci/prow/e2e-aws-scaleup-rhel7 a35d912 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/low labels Apr 29, 2020
@mandre
Copy link
Member

mandre commented Apr 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit d627928 into openshift:master Apr 29, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/installer#3503. Bugzilla bug 1827667 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1827667: openstack: Add jq to the CI image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@pierreprinetti: new pull request created: #3607

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants