Bug 1824991: Update vSphere and Metal UPI for terraform 0.12 #3497

jcpowermac · 2020-04-22T19:46:25Z

Cherry-pick: #3429

- Update to terraform 0.12.x - ipam moved to a module and updated for 0.12 - creation of vsphere objects moved to module - removal of etcd dns records - domain dns records separated from creating rhcos node a records - create load balancer using openshift haproxy image and an additional rhcos virtual machine - create dns A record for lb ip and api, api-int, *.apps - change virtual machine ignition extra config to file path string vs ignition string. Simplifies bootstrap and other instance configuration - Updated Dockerfile CI UPI image for 0.12.24

openshift-ci-robot · 2020-04-22T19:46:29Z

@jcpowermac: This pull request references Bugzilla bug 1824991, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
expected dependent Bugzilla bug 1819492 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1824991: [release-4.4] Update vSphere and Metal UPI for terraform 0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2020-04-22T19:47:46Z

/test e2e-vsphere-upi

jcpowermac · 2020-04-22T20:16:51Z

/test e2e-vsphere-upi

jcpowermac · 2020-04-22T20:31:08Z

/test e2e-vsphere

jcpowermac · 2020-04-23T13:44:36Z

Not enough resources
/test e2e-vsphere

abhinavdahiya · 2020-04-23T16:41:17Z

/approve
/lgtm

openshift-ci-robot · 2020-04-23T16:41:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-24T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-24T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1824991, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
expected dependent Bugzilla bug 1819492 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-24T01:17:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T01:43:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T02:35:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T04:06:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T04:33:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T05:11:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T06:15:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T08:12:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T09:30:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T11:14:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-24T12:19:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-01T21:41:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-02T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-02T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1824991, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1819492 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1819492 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2020-05-13T12:47:39Z

@varungur is there something that needs to be done with this PR to make sure metal is not broken once this is approved?

sdodson · 2020-05-13T12:48:24Z

Can you pick a7ca3ff into this?

sdodson · 2020-05-13T12:53:10Z

/lgtm

sdodson · 2020-05-13T12:53:18Z

/test e2e-metal

sdodson · 2020-05-13T12:53:34Z

/test e2e-vsphere

jcpowermac · 2020-05-13T12:55:28Z

/test e2e-vsphere-upi

openshift-ci-robot · 2020-05-13T12:55:42Z

@jcpowermac: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-fips
/test e2e-aws-proxy
/test e2e-aws-rhel8
/test e2e-aws-scaleup-rhel7
/test e2e-aws-shared-vpc
/test e2e-aws-upgrade
/test e2e-aws-upi
/test e2e-azure
/test e2e-azure-shared-vpc
/test e2e-gcp
/test e2e-gcp-shared-vpc
/test e2e-gcp-upgrade
/test e2e-gcp-upi
/test e2e-libvirt
/test e2e-metal
/test e2e-metal-ipi
/test e2e-openstack
/test e2e-openstack-parallel
/test e2e-ovirt
/test e2e-vsphere
/test gofmt
/test golint
/test govet
/test images
/test shellcheck
/test tf-fmt
/test tf-lint
/test unit
/test verify-vendor
/test yaml-lint

Use /test all to run all jobs.

Details

In response to this:

/test e2e-vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-13T14:04:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-05-13T14:34:29Z

/test e2e-vsphere

sdodson · 2020-05-13T15:29:30Z

Will cherry-pick-approve this later once the branch opens. The installation completed successfully but there are e2e failures in vsphere.

openshift-bot · 2020-05-13T15:35:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T17:06:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T18:24:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T19:16:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-13T19:25:36Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`baca369`	link	`/test e2e-vsphere`
ci/prow/e2e-libvirt	`baca369`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sdodson · 2020-05-13T19:29:12Z

/retitle Bug 1824991: Update vSphere and Metal UPI for terraform 0.12

openshift-ci-robot · 2020-05-13T19:30:14Z

@jcpowermac: All pull requests linked via external trackers have merged: openshift/installer#3497. Bugzilla bug 1824991 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1824991: Update vSphere and Metal UPI for terraform 0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2020-06-10T12:30:18Z

xref https://bugzilla.redhat.com/show_bug.cgi?id=1842906

jcpowermac and others added 3 commits April 22, 2020 15:43

Update matchbox provider version

20164f1

upi/metal: Terraform 0.12.x syntax updates

0a4b085

openshift-ci-robot added the bugzilla/high label Apr 22, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020

openshift-ci-robot requested review from jhixson74 and patrickdillon April 22, 2020 19:46

openshift-ci-robot assigned abhinavdahiya Apr 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 2, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 2, 2020

Updated main.tf to fix syntax issue after move to terraform v0.12

baca369

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2020

openshift-ci-robot assigned sdodson May 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2020

openshift-ci-robot changed the title ~~Bug 1824991: [release-4.4] Update vSphere and Metal UPI for terraform 0.12~~ Bug 1824991: Update vSphere and Metal UPI for terraform 0.12 May 13, 2020

openshift-merge-robot merged commit 35d0984 into openshift:release-4.4 May 13, 2020

Bug 1824991: Update vSphere and Metal UPI for terraform 0.12 #3497

Bug 1824991: Update vSphere and Metal UPI for terraform 0.12 #3497

Uh oh!

Conversation

jcpowermac commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

jcpowermac commented Apr 22, 2020

Uh oh!

jcpowermac commented Apr 22, 2020

Uh oh!

jcpowermac commented Apr 22, 2020

Uh oh!

jcpowermac commented Apr 23, 2020

Uh oh!

abhinavdahiya commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented Apr 24, 2020

Uh oh!

openshift-bot commented May 1, 2020

Uh oh!

openshift-bot commented May 2, 2020

Uh oh!

openshift-ci-robot commented May 2, 2020

Uh oh!

jcpowermac commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

jcpowermac commented May 13, 2020

Uh oh!

openshift-ci-robot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

sdodson commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!