Skip to content

Use CentOS 7 base for CI images. #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Sep 27, 2018
Merged

Use CentOS 7 base for CI images. #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7c9a6
Use CentOS 7 base for CI images.
dgoodwin Sep 27, 2018
a9fc067
Support running installer container as regular user.
dgoodwin Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions images/installer/Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ WORKDIR /go/src/github.com/openshift/installer
COPY . .
RUN hack/build.sh && hack/get-terraform.sh

FROM scratch

FROM centos:7
Copy link
Member

@wking wking Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is effectively what's happening in production, although it's "whatever the OpenShift base layer is" their and not explicitly "CentOS 7". The image I was building for testing openshift/release#1677 is registry.svc.ci.openshift.org/wking-next-gen-installer/stable:installer in case you want to poke around (I think that is public?). The policy doc has:

Do not ask to have your image based of scratch, busybox, alpine, etc. The request will be denied.

I've dropped an internal comment asking why they forbid scratch, and until then, meh, I'm fine either way ;).

COPY --from=build /go/src/github.com/openshift/installer/bin/openshift-install /bin/openshift-install
COPY --from=build /go/src/github.com/openshift/installer/bin/terraform /bin/terraform
RUN mkdir /output && chown 1000:1000 /output
USER 1000:1000
ENV PATH /bin
ENV HOME /
WORKDIR /
ENV HOME /output
WORKDIR /output
ENTRYPOINT ["/bin/openshift-install"]