Skip to content

pkg/types/config: Get the region from the install config #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 27, 2018
Merged

pkg/types/config: Get the region from the install config #346

openshift-merge-robot merged 1 commit into from
Sep 27, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Sep 27, 2018

We haven't set it in the cluster struct yet, that's a few lines below. This was from c6f02ba (#324); likely a copy/paste bug.

/assign @abhinavdahiya

Fixes #324.

@wking
pkg/types/config: Get the region from the install config
bca03af 
We haven't set it in the cluster struct yet, that's a few lines below.
Fixes [1]:

  # openshift-install cluster
  ? Email Address [email protected]
  ? Password [? for help] ********
  ? SSH Public Key <none>
  ? Base Domain REDACTED
  ? Cluster Name dgoodwin1
  ? Pull Secret REDACTED
  ? Platform aws
  ? Region us-east-1 (N. Virginia)
  FATA[0046] failed to generate asset: failed to determine default AMI: MissingRegion: could not find region configuration

and a copy/paste bug from c6f02ba (pkg/cluster/config: add missing
ami fetch, 2018-09-25, openshift#324).

[1]: openshift#335 (comment)
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 27, 2018
@wking wking mentioned this pull request Sep 27, 2018
Merged
abhinavdahiya
abhinavdahiya reviewed Sep 27, 2018
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin
Copy link
Contributor

dgoodwin commented Sep 27, 2018

Appears to fix #335. Could it have fixed #336 as well?

@dgoodwin dgoodwin mentioned this pull request Sep 27, 2018
Closed
@openshift-merge-robot openshift-merge-robot merged commit dd4da22 into openshift:master Sep 27, 2018
@wking wking mentioned this pull request Sep 27, 2018
Closed
@wking wking deleted the fix-region-in-ami-lookup branch September 27, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveej steveej Awaiting requested review from steveej

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @openshift-ci-robot @dgoodwin @abhinavdahiya @openshift-merge-robot