Skip to content

images/installer: Rewrite tectonic-installer for openshift-install #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 27, 2018
Merged

images/installer: Rewrite tectonic-installer for openshift-install #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions images/installer/Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# This Dockerfile is a used by CI to publish openshift/origin-v4.0:installer

FROM openshift/origin-release:golang-1.10 AS build
WORKDIR /go/src/github.com/openshift/installer
COPY . .
RUN hack/build.sh && hack/get-terraform.sh
Copy link
Member Author

@wking wking Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to replace the curl-based get-terraform.sh here with a yum call or some such to comply with Red Hat's OCP Automated Release Policies. But that's probably not too much of a rush. I think get-terraform.sh should stay curl-based to be package-manager agnostic.

Copy link
Contributor

@smarterclayton smarterclayton Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendoring a copy of terraform into a repo is probably the best option if you need a specific tagged commit. If you have to change X at a high rate, the pain you'll feel from RPM iteration will outweigh any ugliness of vendoring.


FROM scratch
COPY --from=build /go/src/github.com/openshift/installer/bin /bin
ENV PATH /bin
ENV HOME /
WORKDIR /
ENTRYPOINT ["/bin/openshift-install"]