Skip to content

Bug 1820591: Add retries to DeleteSwiftContainer #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 14, 2020
Merged

Bug 1820591: Add retries to DeleteSwiftContainer #3408

openshift-merge-robot merged 1 commit into from
May 14, 2020

Conversation

@Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 3, 2020

Now if the function fails, we stop the installation immediately, but it's better to retry several times before finally stopping the installation.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 3, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2020

@Fedosin: This pull request references Bugzilla bug 1820591, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected dependent Bugzilla bug 1816155 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1820584 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1816155 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1820591: Add retries to DeleteSwiftContainer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jstuever
jstuever requested changes Apr 15, 2020
View reviewed changes
pkg/destroy/openstack/swift.go Outdated
Copy link
Contributor

@jstuever jstuever Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these warningf might be better suited with debugf. We normally don't show output if we expect a retry to succeed.

Copy link
Contributor Author

@Fedosin Fedosin Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@Fedosin
Bug 1820591: Add retries to DeleteSwiftContainer
510b1ae 
Now if the function fails, we stop the installation immediately,
but it's better to retry several times before finally stopping the
installation.
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 21, 2020

@Fedosin: This pull request references Bugzilla bug 1820591, which is invalid:

  • expected dependent Bugzilla bug 1816155 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 21, 2020

@Fedosin: This pull request references Bugzilla bug 1820591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1816155 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1820584 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1816155 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • dependent Bugzilla bug 1820584 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 21, 2020

/retest

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 21, 2020

@Fedosin
Presubmit tests will need #3478 to merge before they can succeed

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 23, 2020

/retest

2 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 23, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 24, 2020

/retest

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 29, 2020

/test e2e-openstack

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/low labels Apr 29, 2020
@mandre
Copy link
Member

mandre commented May 14, 2020

Why isn't it an automated cherry-pick of #3407 ?

@mandre
Copy link
Member

mandre commented May 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@pierreprinetti
Copy link
Member

pierreprinetti commented May 14, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@sdodson
Copy link
Member

sdodson commented May 14, 2020

/retitle Bug 1820591: Add retries to DeleteSwiftContainer

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1820591: Add retries to DeleteSwiftContainer Bug 1820591: Add retries to DeleteSwiftContainer May 14, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fdfc548 into openshift:release-4.3 May 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2020

@Fedosin: All pull requests linked via external trackers have merged: openshift/installer#3408. Bugzilla bug 1820591 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1820591: Add retries to DeleteSwiftContainer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever jstuever requested changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Fedosin @openshift-ci-robot @pierreprinetti @mandre @sdodson @openshift-bot @jstuever @openshift-merge-robot