Bug 1819320: os UPI Idempotent server group create #3390

pierreprinetti · 2020-04-01T09:18:19Z

Use the existing server group, if it exists with the target name.

Also convert the call from HTTP to openstackclient for consistency.

/label platform/openstack
/cc @mandre @MaysaMacedo @adduarte

openshift-ci-robot · 2020-04-01T09:18:22Z

@pierreprinetti: This pull request references Bugzilla bug 1819320, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1819320: os UPI Idempotent server group create

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-04-01T09:18:39Z

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-04-01T09:20:17Z

/bugzilla refresh

openshift-ci-robot · 2020-04-01T09:20:24Z

@pierreprinetti: This pull request references Bugzilla bug 1819320, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Use the existing server group, if it exists with the target name. Also convert the call from HTTP to openstackclient for consistency.

MaysaMacedo · 2020-04-01T09:44:32Z

upi/openstack/04_control-plane.yaml

+
+  - name: 'Parse the Server group ID from existing'
+    set_fact:
+      server_group_id: "{{ (server_group_list.stdout | from_json | json_query(list_query) | first).ID }}"


I particularly like the fact that in server group list you get IDs, whereas in server group create you get lowercase ids 🤦‍♂️

MaysaMacedo · 2020-04-01T09:46:44Z

upi/openstack/04_control-plane.yaml

-          - soft-anti-affinity
-    register: cp_group
+    command:
+      cmd: "openstack --os-compute-api-version=2.15 server group create -f json -c id --policy=soft-anti-affinity {{ os_cp_server_group_name }}"


Will this compute api version always be available regardless if it's osp 13 or 16? what happens if it's not?

The maximum microversion supported in Queens (on which OSP13 is based) is 2.60. 2.15 has been introduced in Mitaka, we should have some margin :)

As for the minimum (e.g. "will new OSP versions support old microversions?"), the documentation says that they still target 2.1 as the minimum microversion. No deprecation notice in sight.

MaysaMacedo · 2020-04-01T10:25:11Z

/lgtm

pierreprinetti · 2020-04-01T10:32:17Z

/approve
/retest

openshift-ci-robot · 2020-04-01T10:32:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~upi/openstack/OWNERS~~ [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-01T13:24:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-01T13:50:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-01T14:29:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-01T14:50:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-01T14:55:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-01T14:57:48Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	`804119b`	link	`/test e2e-openstack`
ci/prow/e2e-aws-scaleup-rhel7	`804119b`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-libvirt	`804119b`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-04-01T15:08:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-01T15:13:59Z

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/installer#3390. Bugzilla bug 1819320 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1819320: os UPI Idempotent server group create

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from MaysaMacedo, adduarte and mandre April 1, 2020 09:18

openshift-ci-robot added the platform/openstack label Apr 1, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 1, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 1, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 1, 2020

Bug 1819320: os UPI Idempotent server group create

804119b

Use the existing server group, if it exists with the target name. Also convert the call from HTTP to openstackclient for consistency.

pierreprinetti force-pushed the bug1819320 branch from 1c8c9e8 to 804119b Compare April 1, 2020 09:22

MaysaMacedo reviewed Apr 1, 2020

View reviewed changes

openshift-ci-robot assigned MaysaMacedo Apr 1, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020

openshift-merge-robot merged commit 0bebcea into openshift:master Apr 1, 2020

pierreprinetti deleted the bug1819320 branch April 1, 2020 15:23

Bug 1819320: os UPI Idempotent server group create #3390

Bug 1819320: os UPI Idempotent server group create #3390

Uh oh!

Conversation

pierreprinetti commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

openshift-cherrypick-robot commented Apr 1, 2020

Uh oh!

pierreprinetti commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

MaysaMacedo Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

pierreprinetti Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

pierreprinetti Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

pierreprinetti Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo commented Apr 1, 2020

Uh oh!

pierreprinetti commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Apr 1, 2020 •

edited

Loading