baremetal: Validate os images exist #3363
Conversation
|
/assign @stbenjam |
|
/test e2e-metal-ipi |
There was a problem hiding this comment.
this process is fine, but validations in the other parts of the codebase solve this using modifiers like
installer/pkg/asset/installconfig/aws/validation_test.go
Lines 133 to 142 in c09a610
I'm fine with all of these, but since these builders are not generated, we will end up adding functions for each new field, and most of the times the modifications to the valid examples happens in batches (multiple fields together)
There was a problem hiding this comment.
Potentially the builder could be generated but I wanted to keep it simple, since function for a new field is added only once and very quickly, and after that can be reused by many developers when writing tests.
About batch modifications, not sure If I understood correctly: fluent builders allows modifying multiple fields together through the usage of method chaining (see for example https://github.com/andfasano/installer/blob/ab40687d1715529356df8c22d2b8b0abd3504db0/pkg/types/baremetal/validation/platform_test.go#L54)
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
andfasano
force-pushed
the
validate-osimages-exist
branch
from
ab40687 to
92a07c2
Compare
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
…ied to BootstrapOSImage and ClusterOSImage fields added new validation rule to wrap existing url sanity checks on BootstrapOSImage and ClusterOSImage fields
andfasano
force-pushed
the
validate-osimages-exist
branch
from
92a07c2 to
ccaf134
Compare
|
/test e2e-metal-ipi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
This PR defines a new validation rule
urlexistapplied to theBootstrapOSImageandClusterOSImagefields ofbaremetal.Platformstructure, to ensure that the specified URL exists (without downloading the content).The PR also contains the smallest refactoring step to allows a coherent validation approach for the mentioned fields.
Finally, the PR contains a proposal to improve the readability (and reduce the duplication and the chance of errors) of the related test code using the fluent builder pattern.