Skip to content

Conversation

@jstuever
Copy link
Contributor

This change documents how to add custom tags to the bootstrap, master,
and worker nodes at install time. This will enable users with custom
firewall rules to use previously known tags to enable communications to
their cluster.

This PR depends on: #3309, #3278

@jstuever jstuever changed the title gcp upi: document how to tag the masters and workers WIP: gcp upi: document how to tag the masters and workers Mar 18, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2020
@jstuever
Copy link
Contributor Author

jstuever commented Mar 18, 2020

/cc @patrickdillon
/assign @abhinavdahiya

For quick feedback. Just look at the final commit as this is built on the other PRs. I'll rebase after they land and then reach out for lgtm/approvals.

@abhinavdahiya
Copy link
Contributor

LGTM

This change documents how to add custom tags to the bootstrap, master,
and worker nodes at install time. This will enable users with custom
firewall rules to use previously known tags to enable communications to
their cluster.
@jstuever jstuever changed the title WIP: gcp upi: document how to tag the masters and workers gcp upi: document how to tag the masters and workers Mar 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2020
@jstuever
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2020

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi f3588da2fdce0a862883bf444ba0a6498c3462ea link /test e2e-metal-ipi
ci/prow/e2e-ovirt f3588da2fdce0a862883bf444ba0a6498c3462ea link /test e2e-ovirt
ci/prow/e2e-libvirt f3588da2fdce0a862883bf444ba0a6498c3462ea link /test e2e-libvirt
ci/prow/e2e-aws-fips e216417 link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 e216417 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d376cb1 into openshift:master Mar 31, 2020
@jstuever jstuever deleted the cors1395 branch June 17, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants