Skip to content

libvirt_prefix_deprovision: Fix "for name that are" -> "names" #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 26, 2018
Merged

libvirt_prefix_deprovision: Fix "for name that are" -> "names" #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/destroy/libvirt/libvirt_prefix_deprovision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
// returns true, when the name should be handled.
type filterFunc func(name string) bool

// ClusterNamePrefixFilter returns true for name
// ClusterNamePrefixFilter returns true for names
Copy link
Contributor

@russellb russellb Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change could be made down on L30.

Copy link
Contributor

@russellb russellb Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and it's odd that the AlwaysTrueFilter does not always return true. :-)

Copy link
Member Author

@wking wking Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change could be made down on L30.

Fixed there too with cd617f8 -> dd82979.

// that are prefixed with clustername.
// `clustername` cannot be empty.
var ClusterNamePrefixFilter = func(clustername string) filterFunc {
Expand All @@ -27,7 +27,7 @@ var ClusterNamePrefixFilter = func(clustername string) filterFunc {
}

// AlwaysTrueFilter returns true for all
// name except `default`.
// names except `default`.
var AlwaysTrueFilter = func() filterFunc {
return func(name string) bool {
if name == "default" {
Expand Down