Skip to content

Conversation

@DirectedSoul1
Copy link

This doc needs a few additional steps, for now, I have added to the best of my knowledge.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @DirectedSoul1. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DirectedSoul1
Copy link
Author

@hardys
Copy link

hardys commented Feb 10, 2020

/cc @hardys @russellb @stbenjam

@jstuever
Copy link
Contributor

/uncc @jstuever

@openshift-ci-robot openshift-ci-robot removed the request for review from jstuever February 10, 2020 19:49

Below are some precautions we should follow before even attempting the OCP4.3 Ipv6 deployments.

* [Ipv4-BM-IPI](https://github.com/openshift-kni/baremetal-deploy/blob/master/install-steps.md#preparing-the-provision-node-for-openshift-install) has some pre-requisites which will be applied fpr ipv6 deployments as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bad idea to link out to a GitHub repo not associated with the product.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If there's something specific for baremetal IPI and IPv6, we do have docs in this repo for that (/docs/user/metal). Ideally baremetal-deploy docs that are generally relevant should be added there.

* Worker/Provisioning node
* 3 Master nodes.

Before starting the installation, we need to set up a DNSmasq conf file which will assign IPv6 IP's to all the nodes on `eno3` interface.A sample file is provided below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going fwd there be dragons ... We are pushing lab architecture assumptions on to everyone. This will immediately put us in contention with customer standards.

Added suggested changes.
@abhinavdahiya
Copy link
Contributor

I think this needs to be in docs/dev or docs/user/baremetal .

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hardys
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DirectedSoul1
Copy link
Author

DirectedSoul1 commented Feb 10, 2020

I think this needs to be in docs/dev or docs/user/baremetal .

Moving it to above suggested path(/docs/user/metal) .

@@ -0,0 +1,277 @@
# IPv6 Disconnected Install Troubleshooting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/user/metal/Troubleshooting_Ipv6.md -> docs/user/metal/troubleshooting_ipv6.md

It has content like

## Create a Disconnected Registry

# BootstrapVM cannot download RHCOS image

## Bootstrap VM cannot boot up my nodes

... and more

which talk about general troubleshooting of baremetal ipi and don't seem to be related to ipv6. So i think we should split these into generic and special ipv6 files.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2020
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like feedback is still unaddressed - file needs renaming for one (docs/user/metal/Troubleshooting_Ipv6.md -> docs/user/metal/troubleshooting_ipv6.md). A lot of this is specific to development environments or is general troubleshooting not specific to IPv6. I also think a lot of this could go to baremetal-deploy repo's docs.

Do you plan to revisit this? It's about to get closed.


* [Ipv4-BM-IPI](https://github.com/openshift-kni/baremetal-deploy/blob/master/install-steps.md#preparing-the-provision-node-for-openshift-install) has some pre-requisites which will be applied fpr ipv6 deployments as well.

### The architecture for IPv6 Disconnected Install(Nodes can vary as per requirements)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem specific to a development/testing environment. I don't think I'd want these documented here


Below are some precautions we should follow before even attempting the OCP4 Ipv6 deployments.

* [Ipv4-BM-IPI](https://github.com/openshift-kni/baremetal-deploy/blob/master/install-steps.md#preparing-the-provision-node-for-openshift-install) has some pre-requisites which will be applied fpr ipv6 deployments as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is stale

@rlopez133
Copy link
Contributor

Looks like feedback is still unaddressed - file needs renaming for one (docs/user/metal/Troubleshooting_Ipv6.md -> docs/user/metal/troubleshooting_ipv6.md). A lot of this is specific to development environments or is general troubleshooting not specific to IPv6. I also think a lot of this could go to baremetal-deploy repo's docs.

Do you plan to revisit this? It's about to get closed.

This was opened before we had all the docs we have in the baremetal-deploy repo. Since this was PR'ed, a lot of changes have been put in place. In fact, we are in the process of updating the troubleshooting docs even further in the baremetal-deploy repo.

@stbenjam
Copy link
Member

stbenjam commented Jun 5, 2020

/close

@openshift-ci-robot
Copy link
Contributor

@stbenjam: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants