-
Notifications
You must be signed in to change notification settings - Fork 1.5k
GCP: Move gcp-routes script and service into bootstrap data #3073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ctly This would ensure bootstrap node reports as healthy to GCP LBs
|
@cgwalters @vrutkovs please review the second commit to make sure those changes are sane |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1ac5f9d to
96c35e6
Compare
|
/hold I do not want the installer to maintain this script for GCP. |
|
This will probably be moved into afterburn for the FCOS case |
|
@LorbusChris: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- What I did
This PR adds a script and service unit to the GCP templates that ensures GCP routes are set corrently.
These files are already baked into RHCOS by the build system, but we'd like to move them out of there and into installer (for bootstrap nodes) and MCO (for masters/workers).
The analogous MCO PR is openshift/machine-config-operator#1449
- How to verify it
CI