Skip to content

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Feb 6, 2020

- What I did
This PR adds a script and service unit to the GCP templates that ensures GCP routes are set corrently.
These files are already baked into RHCOS by the build system, but we'd like to move them out of there and into installer (for bootstrap nodes) and MCO (for masters/workers).
The analogous MCO PR is openshift/machine-config-operator#1449

- How to verify it
CI

…ctly

This would ensure bootstrap node reports as healthy to GCP LBs
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2020
@LorbusChris
Copy link
Contributor Author

@cgwalters @vrutkovs please review the second commit to make sure those changes are sane

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

/hold

I do not want the installer to maintain this script for GCP.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Feb 7, 2020

This will probably be moved into afterburn for the FCOS case
/close

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: Closed this PR.

Details

In response to this:

This will probably be moved into afterburn
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 96c35e6 link /test e2e-libvirt
ci/prow/e2e-openstack 96c35e6 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 96c35e6 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants