Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 21, 2018

TEST PR In local testing this AMI has been shown to fail, testing here to confirm

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveej

If they are not already assigned, you can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2018
@sallyom sallyom changed the title bump the AMI to ami-0f8aa81e573244ca6 bump the AMI to ami-09b1c714bf5aaa535 Sep 21, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2018
@wking
Copy link
Member

wking commented Sep 21, 2018

Success with ami-0f8aa81e573244ca6 (build log, AMI passed to Terraform). Looks like you're testing ami-09b1c714bf5aaa535 now?

@sallyom
Copy link
Contributor Author

sallyom commented Sep 21, 2018

Yea, my test with ami-0f8aa81e573244ca6 failed unit test, bc I didn't edit kubesystem.yaml or terraform.tfvars I updated the ami/then figured that out.. so, now I'm testing ami-09b1c714bf5aaa535, yes.. want to bump to this if it passes?

@wking
Copy link
Member

wking commented Sep 21, 2018

Yea, my test with ami-0f8aa81e573244ca6 failed unit test... so, now I'm testing ami-09b1c714bf5aaa535, yes.. want to bump to this if it passes?

I wouldn't worry about unit tests. #290 (just green on ami-09b1c714bf5aaa535) is moving us to floating with the most recent AMI, which will mean we can stop manually bumping our pinned ID. Just close this PR when you're satisfied (and you can re-open later if you want to use it to test other AMIs)

@sallyom
Copy link
Contributor Author

sallyom commented Sep 21, 2018

👍 ok

@sallyom sallyom closed this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants