Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable #3034

stbenjam · 2020-01-31T14:34:07Z

Backport of #2895

This change adds 4 new options to the baremetal platform:

    - ProvisioningNetworkInterface
    - ProvisioningNetworkCIDR
    - ProvisioningDHCPExternal
    - ProvisioningDHCPRange

This makes the provisioning network more configurable, by allowing users
to specify a specific network interface, which network, and settings for
whether the cluster should provide DHCP services on the provisioning
network, or if it will be managed externally. If we will provide DHCP
services on the network, the user may further customize which range to
use.

This change is a prerequisite to a number of additional high-priority
work items for the baremetal IPI platform, including single-stack IPv6
provisioning, external DHCP support, and end-to-end seamless deployment
without a manually created config map.

Co-authored-by: Ian Main [email protected]
Co-authored-by: Stephen Benjamin [email protected]

This change adds 4 new options to the baremetal platform: - ProvisioningNetworkInterface - ProvisioningNetworkCIDR - ProvisioningDHCPExternal - ProvisioningDHCPRange This makes the provisioning network more configurable, by allowing users to specify a specific network interface, which network, and settings for whether the cluster should provide DHCP services on the provisioning network, or if it will be managed externally. If we will provide DHCP services on the network, the user may further customize which range to use. This change is a prerequisite to a number of additional high-priority work items for the baremetal IPI platform, including single-stack IPv6 provisioning, external DHCP support, and end-to-end seamless deployment without a manually created config map. Co-authored-by: Ian Main <[email protected]> Co-authored-by: Stephen Benjamin <[email protected]>

stbenjam · 2020-01-31T14:34:27Z

/hold

Need to verify what's in the 4.3 ironic containers first

openshift-ci-robot · 2020-01-31T14:35:11Z

@stbenjam: This pull request references Bugzilla bug 1796930, which is invalid:

expected dependent Bugzilla bug 1796929 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T13:56:46Z

/close

Not required in 4.3.

openshift-ci-robot · 2020-02-12T13:56:48Z

@stbenjam: Closed this PR.

Details

In response to this:

/close

Not required in 4.3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T14:32:39Z

/reopen

openshift-ci-robot · 2020-02-12T14:32:41Z

@stbenjam: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-12T14:32:42Z

@stbenjam: This pull request references Bugzilla bug 1796930, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (WONTFIX) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T14:34:38Z

/bugzilla refresh

openshift-ci-robot · 2020-02-12T14:34:41Z

@stbenjam: This pull request references Bugzilla bug 1796930, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (WONTFIX) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T14:35:47Z

/bugzilla refresh

openshift-ci-robot · 2020-02-12T14:35:55Z

@stbenjam: This pull request references Bugzilla bug 1796930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T14:35:58Z

/hold cancel

stbenjam · 2020-02-12T14:41:48Z

/hold

Actually still need to check ironic containers in 4.3

russellb · 2020-02-12T15:52:00Z

Can you link to the corresponding master PR(s)?

openshift-ci-robot · 2020-02-12T15:57:09Z

@stbenjam: This pull request references Bugzilla bug 1796930, which is valid.

Details

In response to this:

Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-02-12T15:57:23Z

@russellb Done. It's in the description now.

This is a backport of #2895

openshift-ci-robot · 2020-02-12T16:37:51Z

@stbenjam: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`695ef58`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

russellb · 2020-02-12T18:39:24Z

/lgtm

sdodson · 2020-02-14T16:59:31Z

/approve
Still has a hold on it though, clear that?

openshift-ci-robot · 2020-02-14T17:00:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bparees · 2020-02-19T19:02:12Z

@stbenjam still held so not currently being considered for cherry pick approval

hardys · 2020-02-20T16:25:36Z

@stbenjam looks like we need to cherry-pick openshift/ironic-image#45 to unblock this?

stbenjam · 2020-02-20T16:29:29Z

Since we are about to get iPXE images for ironic-image, I was going to get that in ironic-image and backport all the IPv6 things together.

bparees · 2020-02-20T22:00:15Z

skipping this one for approval this week anyway due to the number of other changes already accepted.

sdodson · 2020-03-10T17:00:18Z

@stbenjam Are we moving forward with this PR?

stbenjam · 2020-03-10T17:11:12Z

No - this was tightly coupled to the IPv6 work in the ironic-image, and we're not going to split this out. Only in 4.4+ will provisioning networks be configurable.

/close

openshift-ci-robot · 2020-03-10T17:11:14Z

@stbenjam: Closed this PR.

Details

In response to this:

No - this was tightly coupled to the IPv6 work in the ironic-image, and we're not going to split this out. Only in 4.4+ will provisioning networks be configurable.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2020

openshift-ci-robot requested review from jcpowermac and russellb January 31, 2020 14:42

stbenjam mentioned this pull request Feb 6, 2020

Bug 1794698: Last batch of changes to be backported to 4.3 openshift/ironic-image#49

Closed

openshift-ci-robot closed this Feb 12, 2020

openshift-ci-robot reopened this Feb 12, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 12, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020

stbenjam mentioned this pull request Feb 12, 2020

[release-4.3] Bug 1802198: baremetal: Changes needed for IPv6 #3097

Closed

openshift-ci-robot assigned russellb Feb 12, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020

openshift-ci-robot closed this Mar 10, 2020

Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable #3034

Bug 1796930: [release-4.3] baremetal: make provisioning networks more configurable #3034

Uh oh!

Conversation

stbenjam commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stbenjam commented Jan 31, 2020

Uh oh!

openshift-ci-robot commented Jan 31, 2020

Uh oh!

stbenjam commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

russellb commented Feb 12, 2020

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

stbenjam commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 12, 2020

Uh oh!

russellb commented Feb 12, 2020

Uh oh!

sdodson commented Feb 14, 2020

Uh oh!

openshift-ci-robot commented Feb 14, 2020

Uh oh!

bparees commented Feb 19, 2020

Uh oh!

hardys commented Feb 20, 2020

Uh oh!

stbenjam commented Feb 20, 2020

Uh oh!

bparees commented Feb 20, 2020

Uh oh!

sdodson commented Mar 10, 2020

Uh oh!

stbenjam commented Mar 10, 2020

Uh oh!

openshift-ci-robot commented Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

stbenjam commented Jan 31, 2020 •

edited

Loading

stbenjam commented Feb 12, 2020 •

edited

Loading

stbenjam commented Feb 12, 2020 •

edited

Loading