Add import ova for vSphere #2970
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Most of this should be made private or internal package imo. Also this changeset would benefit a lot from from comments/internal doc/commit message to explain the process of importing/creating a VM template. |
jcpowermac
force-pushed
the
CORS-1337-2
branch
from
825894a to
0657a80
Compare
openshift-ci-robot
added
the
needs-rebase
This change caches a copy of the vmware ova specified in rhcos.json in preperation to upload the OVA into a Template.
jcpowermac
force-pushed
the
CORS-1337-2
branch
from
0657a80 to
b528b8c
Compare
openshift-ci-robot
removed
the
needs-rebase
jcpowermac
force-pushed
the
CORS-1337-2
branch
from
b528b8c to
22e0564
Compare
Used @jstuever branch as the basis of this change. `import.go` implements the ability for the installer to import an RHCOS OVA into vSphere. `findImportOvaParams` will only provide a HostSystem that contains the Network and Datastore provided for the import process. Used `govc/importx/archive.go` which is required to retrieve the Ovf Envelope
jcpowermac
force-pushed
the
CORS-1337-2
branch
from
22e0564 to
8d0ff52
Compare
jcpowermac
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jcpowermac
force-pushed
the
CORS-1337-2
branch
from
8d0ff52 to
f73b77a
Compare
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
patrickdillon
left a comment
patrickdillon
left a comment
There was a problem hiding this comment.
I just gave this a quick review, but I have some questions around the vendor/copy of govmomi code.
|
|
||
| baseURL := base.ResolveReference(image).String() | ||
|
|
||
| // TODO: Get Uncompressed SHA256 into rhcos.json |
There was a problem hiding this comment.
What is this contingent on? If this seems like a lot of work, I think delete the comment and create a card.
| return &ArchiveFlag{}, ctx | ||
| } | ||
|
|
||
| // Register ArchiveFlag |
There was a problem hiding this comment.
It seems like the only thing being changed from the govmomi repo is adding some comments. These are exported types so I would think we should be able to use these just from the vendored code and not copy here...
There was a problem hiding this comment.
It's a technical reason... the things we need from the vendored code is not exportable. Therefore, we copied file(s) here with a modified package vsphere thereby making them accessible.
|
@jcpowermac: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
/close |
|
@jcpowermac: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This PR requires #2922
Used @jstuever branch as the basis of this change.
import.goimplements the ability for the installer toimport an RHCOS OVA into vSphere.
findImportOvaParamswill only provide a HostSystemthat contains the Network and Datastore provided for
the import process.
Used
govc/importx/archive.gowhich is requiredto retrieve the Ovf Envelope