Swiftless OpenStack: store bootstrap ignition configs in Glance #2960

Fedosin · 2020-01-22T17:31:52Z

Now we store bootstrap ignition configs in Swift storage, but unfortunately Swift is not available on all OpenStack clouds. It leads to the fact that we can't deploy OpenShift on such swiftless clouds.

This PR allows to store configs in Glance, which is available on 100% of OpenStack clouds.

The newest version includes important features, like HTTP headers support, that are required for the successful installation of OpenShift on OpenStack without Swift.

Fedosin · 2020-01-22T18:18:08Z

openstack tests will fail until we upgrade the rhcos image in the installer

Fedosin · 2020-01-22T21:40:27Z

/retest

Fedosin · 2020-01-22T23:35:41Z

/retest

Fedosin · 2020-01-23T08:02:01Z

/retest

Fedosin · 2020-01-23T10:45:25Z

/test e2e-aws

pierreprinetti · 2020-01-23T13:04:11Z

/retest

Fedosin · 2020-01-23T13:37:18Z

/retest

wking · 2020-01-23T23:48:44Z

Looks like the OpenStack job failed to come up? AWS came up fine, so the bump to Ignition spec 2.4 doesn't seem to have caused a problem. Still would be nice to see those green though.

/retest

abhinavdahiya · 2020-01-23T23:53:44Z

Dropping the Swift from destroy means that if I created a cluster using 4.2 and tried to destroy the closer with this new installer, we leak the Swift objects

iamemilio · 2020-01-24T00:53:44Z

That's a good point. I think we have to support swift deletion indefinitely.

iamemilio · 2020-01-24T02:04:51Z

Once you address Abhinav's comment, LGTM

wking · 2020-01-24T03:41:23Z

Hmm, fresh OpenStack run died the same way?

Fedosin · 2020-01-24T04:00:33Z

@wking yeah,to make OpenStack test pass we need to bump Ignition in the pre-release image first: https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/
Because the minimal required Ignition version for this change is 0.35.
For instance, the latest 4.3 release already has it: https://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/4.3/latest/

Fedosin · 2020-01-24T04:14:51Z

@abhinavdahiya I didn't drop Swift from the destroy module. I just added a check that if there is no Swift service we are fine with it: https://github.com/openshift/installer/pull/2960/files#diff-3420abf882f61be73bc30ef12460687dR547-R550 deleteContainers function in pkg/destroy/openstack/openstack.go
So, cluster destruction will work on all OCP versions after this change.

I removed Swift code from bootstrap destruction (pkg/destroy/openstack/swift.go), and I think this is right. Now we create a Swift container, upload the config there, give the link to the bootstrap machine and then immediately destroy the container when bootstrapping is over using DeleteSwiftContainer function from pkg/destroy/openstack/swift.go.
With this patch instead of creating a container, we do the same things with Glance image.

So, this patch only affects the bootstrapping process and all other parts stay the same.

wking · 2020-01-24T04:40:55Z

pkg/destroy/openstack/swift.go

-)
-
-// DeleteSwiftContainer deletes a container and all of its objects.
-func DeleteSwiftContainer(name string, cloud string) error {


It is strange that you can now safely remove this. What if folks want to delete a cluster created by a previous installer (and so using Swift) which got a Swift bootstrap Ignition store, but then failed to install. Wouldn't that leak the Swift container with destroy cluster not using this function? Of course, the fact that nothing else in pkg/destroy/openstack calls this function means that leak is not new in this PR. But it still seems like a leak to me.

Never mind, @Fedosin points out that this function was pretty similar to deleteContainers, which is left alone by this PR.

pierreprinetti · 2020-01-24T08:02:04Z

/retest

mandre · 2020-01-24T08:20:54Z

/lgtm
/hold until we bump the rhcos image #2971

Fedosin · 2020-01-24T10:59:58Z

openstack tests are green with the RHCOS bump #2971: #2973

sdodson · 2020-01-24T13:18:20Z

/approve

openshift-ci-robot · 2020-01-24T13:18:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fedosin · 2020-01-24T13:26:52Z

/test e2e-openstack

Fedosin · 2020-01-24T14:47:29Z

openstack tests are green

Fedosin · 2020-01-24T14:47:36Z

/hold cancel

openshift-bot · 2020-01-24T15:39:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T15:52:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T16:47:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T18:02:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-24T19:40:41Z

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	`52d52b9`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-scaleup-rhel7	`52d52b9`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Some openstack environments do not allow users to upload or download image data. This is because the cloud providers prevent them from using illegal images on the openstack or getting proprietary images on a local. This PR is based on the Swift functions removed in PR openshift#2960 and adds the feature to store a ignition file in Swift when an upload in Glance fails, as follows: Glance | Swift | used enable | enable | storage --------+--------+--------- v | v | Glance v | | Glance | v | Swift <- this PR | | none Signed-off-by: ERAMOTO Masaya <[email protected]>

Bump Ignition and Gophercloud

bc4e0e5

The newest version includes important features, like HTTP headers support, that are required for the successful installation of OpenShift on OpenStack without Swift.

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2020

openshift-ci-robot requested review from jcpowermac and jhixson74 January 22, 2020 17:34

Swiftless OpenStack: store bootstrap ignition configs in Glance

52d52b9

Fedosin force-pushed the swiftless branch from b33ff81 to 52d52b9 Compare January 22, 2020 17:40

wking reviewed Jan 24, 2020

View reviewed changes

wking mentioned this pull request Jan 24, 2020

Bump RHCOS to 44.81.202001240222.0 #2971

Merged

Fedosin mentioned this pull request Jan 24, 2020

Do Not Review: Swiftless test #2973

Closed

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020

openshift-ci-robot assigned mandre Jan 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020

openshift-merge-robot merged commit 75ad924 into openshift:master Jan 24, 2020

Fedosin mentioned this pull request Jan 30, 2020

[release-4.3] Swiftless OpenStack: store bootstrap ignition configs in Glance #3022

Closed

eramoto mentioned this pull request Sep 29, 2022

OpenStack: Store ignition file in Swift when the upload in Glance fails #6431

Closed

Swiftless OpenStack: store bootstrap ignition configs in Glance #2960

Swiftless OpenStack: store bootstrap ignition configs in Glance #2960

Uh oh!

Conversation

Fedosin commented Jan 22, 2020

Uh oh!

Fedosin commented Jan 22, 2020

Uh oh!

Fedosin commented Jan 22, 2020

Uh oh!

Fedosin commented Jan 22, 2020

Uh oh!

Fedosin commented Jan 23, 2020

Uh oh!

Fedosin commented Jan 23, 2020

Uh oh!

pierreprinetti commented Jan 23, 2020

Uh oh!

Fedosin commented Jan 23, 2020

Uh oh!

wking commented Jan 23, 2020

Uh oh!

abhinavdahiya commented Jan 23, 2020

Uh oh!

iamemilio commented Jan 24, 2020

Uh oh!

iamemilio commented Jan 24, 2020

Uh oh!

wking commented Jan 24, 2020

Uh oh!

Fedosin commented Jan 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fedosin commented Jan 24, 2020

Uh oh!

wking Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

wking Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

pierreprinetti commented Jan 24, 2020

Uh oh!

mandre commented Jan 24, 2020

Uh oh!

Fedosin commented Jan 24, 2020

Uh oh!

sdodson commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

Fedosin commented Jan 24, 2020

Uh oh!

Fedosin commented Jan 24, 2020

Uh oh!

Fedosin commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Fedosin commented Jan 24, 2020 •

edited

Loading