[release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses #2944

openshift-cherrypick-robot · 2020-01-17T21:16:33Z

This is an automated cherry-pick of #2939

/assign stbenjam

The installer creates a manifest for proxy configuration, automatically adding specific addresses to NO_PROXY depending on the platform. One of those addresses is the metadata service, hosted at 169.254.169.254. The installer assumes this must be done for all platforms other than None of vSphere, whereas the cluster-network-operator has an explicit list of platforms: https://github.com/openshift/cluster-network-operator/blob/adaf257b4d63661726443ab2b059a9b4209a02d1/pkg/util/proxyconfig/no_proxy.go#L67-L69 When using a proxy with baremetal IPI, the installer adds this address, however when the CNO comes up, it does not, causing the rendered machine configs to differ, and installation to fail, with MCO reporting errors like: ``` pool master has not progressed to latest configuration: configuration status for pool master is empty: pool is degraded because nodes fail with "3 nodes are reporting degraded status on sync": "Node master-1 is reporting: \"machineconfig.machineconfiguration.openshift.io \\\"rendered-master-982b8698753da7e31b5f902aa4dc135e\\\" not found\"" ``` This needs a better, longer term solution to ensure the installer and CNO are not creating conflicting proxy objects, however as a short-term fix that is easily backportable to 4.3 to ensure proxies work on baremetal, this syncs the two lists between the installer and CNO.

openshift-ci-robot · 2020-01-17T21:16:36Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1791993, which is invalid:

expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1791993 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1791993: proxy: use explicit list of platforms for metadata addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-01-17T21:21:35Z

/retitle [release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses

openshift-ci-robot · 2020-01-17T21:21:39Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1791995, which is invalid:

expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-01-17T21:36:07Z

/lgtm
/approve

openshift-ci-robot · 2020-01-17T21:36:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-18T17:42:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T17:55:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T18:08:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T18:21:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T18:34:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T18:47:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T19:00:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T19:13:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T19:26:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T19:39:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T19:52:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T20:05:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T20:18:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T20:31:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T21:23:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T21:36:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T21:49:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T22:02:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T22:15:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T22:28:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T22:54:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T23:07:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T23:20:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-18T23:59:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T00:12:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T00:25:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T00:38:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T01:04:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T01:31:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T02:09:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-19T03:27:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stbenjam · 2020-01-23T15:01:47Z

/bugzilla refresh

openshift-ci-robot · 2020-01-23T15:01:52Z

@stbenjam: This pull request references Bugzilla bug 1791995, which is invalid:

expected dependent Bugzilla bug 1791993 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-03-19T16:56:55Z

/bugzilla refresh

openshift-ci-robot · 2020-03-19T16:57:02Z

@stbenjam: This pull request references Bugzilla bug 1791995, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1791993 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1791993 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-03-20T02:24:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-20T02:50:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-20T03:04:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-20T04:08:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-20T05:30:25Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1791995 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned stbenjam Jan 17, 2020

openshift-cherrypick-robot mentioned this pull request Jan 17, 2020

Bug 1791993: proxy: use explicit list of platforms for metadata addresses #2939

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 17, 2020

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2020

openshift-ci-robot requested review from jcpowermac and jhixson74 January 17, 2020 21:17

openshift-ci-robot changed the title ~~[release-4.3] Bug 1791993: proxy: use explicit list of platforms for metadata addresses~~ [release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses Jan 17, 2020

openshift-ci-robot assigned sdodson Jan 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2020

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 20, 2020

openshift-merge-robot merged commit 1fe824d into openshift:release-4.3 Mar 20, 2020

[release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses #2944

[release-4.3] Bug 1791995: proxy: use explicit list of platforms for metadata addresses #2944

Uh oh!

Conversation

openshift-cherrypick-robot commented Jan 17, 2020

Uh oh!

openshift-ci-robot commented Jan 17, 2020

Uh oh!

stbenjam commented Jan 17, 2020

Uh oh!

openshift-ci-robot commented Jan 17, 2020

Uh oh!

sdodson commented Jan 17, 2020

Uh oh!

openshift-ci-robot commented Jan 17, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 18, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

openshift-bot commented Jan 19, 2020

Uh oh!

stbenjam commented Jan 23, 2020

Uh oh!