Skip to content

Add gather bootstrap for vsphere #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 25, 2020
Merged

Add gather bootstrap for vsphere #2912

openshift-merge-robot merged 1 commit into from
Jan 25, 2020

Conversation

@jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Jan 14, 2020

Use terraform state to find virtual machines
managed object reference value (vm-#).
Using the value create a ManagedObjectReference
to create a NewVirtualMachine.
For each vm wait for the ip address and return results

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 14, 2020

This needs to be tested.

jstuever
jstuever reviewed Jan 15, 2020
View reviewed changes
patrickdillon
patrickdillon reviewed Jan 17, 2020
View reviewed changes
@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 17, 2020

In general this looks good to me.

patrickdillon
patrickdillon reviewed Jan 23, 2020
View reviewed changes
@jcpowermac
Add gather bootstrap for vsphere
56d70ac 
Use terraform state to find virtual machines
managed object reference value (vm-#).
Using the value create a ManagedObjectReference
to create a NewVirtualMachine.
For each vm wait for the ip address and return results
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 23, 2020

@patrickdillon updated, ptal

@jcpowermac jcpowermac changed the title [wip] Add gather bootstrap for vsphere Add gather bootstrap for vsphere Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 24, 2020

Tested and it works.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@sdodson
Copy link
Member

sdodson commented Jan 24, 2020

/approve

@sdodson
Copy link
Member

sdodson commented Jan 24, 2020

/test images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ee1b793 into openshift:master Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 56d70ac link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 56d70ac link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@jstuever jstuever jstuever left review comments

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jcpowermac @patrickdillon @sdodson @openshift-ci-robot @openshift-bot @jstuever @openshift-merge-robot