Skip to content

*: Remove remaining tectonic-torcx references #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
squat merged 1 commit into from
Jul 6, 2018
Merged

*: Remove remaining tectonic-torcx references #29

squat merged 1 commit into from
Jul 6, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Jul 6, 2018

These should have been removed by 45fa0e4 (coreos/tectonic-installer#3275).

@wking
*: Remove remaining tectonic-torcx references
227ed73 
These should have been removed by 45fa0e4 (*: remove
k8s-node-bootstrap.service, 2018-06-08,
coreos/tectonic-installer#3275).
@coreosbot
Copy link

coreosbot commented Jul 6, 2018

Can one of the admins verify this patch?

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2018
@squat
Copy link
Contributor

squat commented Jul 6, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2018
@squat
Copy link
Contributor

squat commented Jul 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 6, 2018

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 227ed73 link /test e2e-aws
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squat squat merged commit ecc5110 into openshift:master Jul 6, 2018
@wking
Copy link
Member Author

wking commented Jul 6, 2018

Is the e2e-aws failure a known flake?

operator Instantiate the template e2e-aws into the operator namespace and wait for any pods to complete 8m21s
go run hack/e2e.go -v -test --test_args='--ginkgo.focus=operator\sInstantiate\sthe\stemplate\se2e\-aws\sinto\sthe\soperator\snamespace\sand\swait\sfor\sany\spods\sto\scomplete$'
the pod ci-op-562b2q9r/e2e-aws failed after 8m15s (failed containers: setup, test):  unknown

Container setup exited with code 1, reason Error
Container test exited with code 1, reason Error

@wking wking deleted the tectonic-torcx-cleanup branch July 6, 2018 23:52
This was referenced Jul 7, 2018
Merged
Merged
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Apr 30, 2019
@derekhiggins
Merge pull request openshift#29 from celebdor/multicluster-single-brd
0447ab1 
keepalived: separate by cluster
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Feb 10, 2021
@openshift-merge-robot
Merge pull request openshift#29 from sadasu/metal3
c20a3cb 
Add secrets required to create metal3 Deployment
clnperez pushed a commit to clnperez/installer that referenced this pull request Jul 28, 2021
@bpradipt
Merge pull request openshift#29 from mkumatag/use_base_config
70c3dde 
Use domain variables from the base config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@squat squat squat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@squat squat

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @coreosbot @squat @openshift-ci-robot