Skip to content

doc: Update dependency graph. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yifan-gu wants to merge 1 commit into from
Closed

doc: Update dependency graph. #288

yifan-gu wants to merge 1 commit into from

Conversation

@yifan-gu
Copy link
Contributor

@yifan-gu yifan-gu commented Sep 20, 2018 •
edited
Loading

Add terraform tfvars file as a dependency of the tfstate.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yifan-gu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 20, 2018
@yifan-gu yifan-gu force-pushed the update_graph branch 2 times, most recently from 6872e25 to 988d84c Compare September 20, 2018 01:26
crawford
crawford reviewed Sep 20, 2018
View reviewed changes
Documentation/design/resource_dep.dot Outdated
Copy link
Contributor

@crawford crawford Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reserve the cluster target for if/when the installer invokes terraform on behalf of the user. Maybe call this target cluster-inputs?

@yifan-gu yifan-gu force-pushed the update_graph branch 2 times, most recently from dffde13 to f2ccc15 Compare September 20, 2018 01:31
@yifan-gu yifan-gu mentioned this pull request Sep 20, 2018
Merged
wking
wking reviewed Sep 20, 2018
View reviewed changes
Documentation/design/resource_dep.dot Outdated
Copy link
Member

@wking wking Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinction between cluster and openshift_cluster is not clear to me, especially with openshift_cluster -> cluster. Can we get more descriptive names for these? Or maybe drop clusterand renameopenshift_cluster->cluster`?

@crawford
Copy link
Contributor

crawford commented Sep 26, 2018

@yifan-gu Can you update this or close it?

@yifan-gu yifan-gu force-pushed the update_graph branch 2 times, most recently from 0d8a712 to 04f6875 Compare September 26, 2018 22:01
doc: Update dependency graph.
524c9bf 
Add terraform tfvars file as a dependency of the tfstate.
@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 26, 2018

Going to drop this, I feel the current is good enough.

@yifan-gu yifan-gu closed this Sep 26, 2018
@yifan-gu yifan-gu deleted the update_graph branch September 26, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

+1 more reviewer

@crawford crawford crawford left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yifan-gu @openshift-ci-robot @crawford @wking