Skip to content

Bug 1791457: [release-4.3] Add support for AWS Bahrain region me-south-1 #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Feb 12, 2020
Merged

Bug 1791457: [release-4.3] Add support for AWS Bahrain region me-south-1 #2877

openshift-merge-robot merged 3 commits into from
Feb 12, 2020

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Jan 3, 2020 •
edited
Loading

4.3 variant of #2826
cherry-picks 2 out of 4 of those commits
manually update Gopkg.toml and run dep ensure
separate commit to bump RHCOS release image for 4.3

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2020

@patrickdillon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] Add support for AWS Bahrain region me-south-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 3, 2020
@jcpowermac
Copy link
Contributor

jcpowermac commented Jan 3, 2020

/test e2e-vsphere

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jan 3, 2020

@sdodson should I create a bz for this (and forthcoming 4.2) to get this into 4.3?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2020

@patrickdillon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] Add support for AWS Bahrain region me-south-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jan 9, 2020

should I create a bz for this (and forthcoming 4.2) to get this into 4.3?

If we want to backport this feature to 4.2 and 4.3, then yes, we'll need bugs to motivate the backports.

@patrickdillon patrickdillon changed the title [release-4.3] Add support for AWS Bahrain region me-south-1 Bug 1791457: [release-4.3] Add support for AWS Bahrain region me-south-1 Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

@patrickdillon: This pull request references Bugzilla bug 1791457, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead
  • expected Bugzilla bug 1791457 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1791457: [release-4.3] Add support for AWS Bahrain region me-south-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2020
@patrickdillon
Add Support for Bahrain me-south-1 AWS region
bc58e31 
Updates validation to allow installing in the me-south-1 Bahrain region in AWS.
@patrickdillon
Skip verification of aws me-south-1 Bahrain region in Terraform provi…
e581160 
…der.

Support for me-south-1 was added in the v2.22 aws terraform provider. This commit can be reverted if provider is updated.
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2020
@patrickdillon
Vendor: bump AWS SDK to allow cluster destroy in me-south-1
0516623 
This is a result of editing Gopkg.toml and runnning dep ensure.
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2020
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jan 15, 2020

Removed the RHCOS bump because it was already satisfied by 079c813

@sdodson
Copy link
Member

sdodson commented Jan 30, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2020

@sdodson: This pull request references Bugzilla bug 1791457, which is invalid:

  • expected dependent Bugzilla bug 1796651 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jan 31, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 31, 2020

@sdodson: This pull request references Bugzilla bug 1791457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 31, 2020
@sdodson
Copy link
Member

sdodson commented Jan 31, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@sdodson
Copy link
Member

sdodson commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 12, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9e15843 into openshift:release-4.3 Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2020

@patrickdillon: All pull requests linked via external trackers have merged. Bugzilla bug 1791457 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1791457: [release-4.3] Add support for AWS Bahrain region me-south-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. queue/blocks-others size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@patrickdillon @openshift-ci-robot @jcpowermac @wking @sdodson @openshift-bot @mfojtik @openshift-merge-robot