Skip to content

vSphere IPI: vendor machine-api-operator for VSphereMachineProviderSpec #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcpowermac wants to merge 1 commit into from
Closed

vSphere IPI: vendor machine-api-operator for VSphereMachineProviderSpec #2861

jcpowermac wants to merge 1 commit into from

Conversation

@jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Dec 20, 2019

Add machine-api-operator dependency for VSphereMachineProviderSpec.

@jcpowermac
vSphere IPI: vendor machine-api-operator for VSphereMachineProviderSpec
2e7dc7a 
Probably another way but I added the stub
of `pkg/tfvars/vsphere/vsphere.go` to get around
`dep ensure` errors.
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 20, 2019
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Dec 20, 2019

Third times the charm :)

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 2, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2020

@jcpowermac: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 2e7dc7a link /test e2e-openstack
ci/prow/e2e-libvirt 2e7dc7a link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac jcpowermac mentioned this pull request Jan 2, 2020
Merged
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jan 2, 2020

Closing. Add vendor to:
#2841

@jcpowermac jcpowermac closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcpowermac @openshift-ci-robot