config/validator/s3bucket: remove TNC references

[steveej]

Remove this confusing reference as the S3 bucket validation is not
related to TNC in any way.

[wking]

... S3 bucket validation is not related to TNC in any way.

Since ab1e53e (#162):

$ git show ab1e53e207
$ git show ab1e53e207 | grep 'bucket =.*tectonic_base_domain'
-  bucket = "${lower(var.tectonic_cluster_name)}-tnc.${var.tectonic_base_domain}"
+  bucket = "${lower(var.tectonic_cluster_name)}.${var.tectonic_base_domain}"

;).

Also, looks like you missed a reference:

# github.com/openshift/installer/installer/pkg/config
installer/pkg/config/validate_test.go:398:22: c.cluster.validateTNCS3Bucket undefined (type Cluster has no field or method validateTNCS3Bucket)

[steveej]

/retest

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveeJ, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [steveeJ,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment