Skip to content

Conversation

@imain
Copy link
Contributor

@imain imain commented Dec 19, 2019

Create a new baremetal deployment CRD containing all the elements needed
to configure the baremetal deployment.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@imain
Copy link
Contributor Author

imain commented Dec 19, 2019

Marked as WIP as I still need to add tests and properly functionally test. This patch also includes the vendoring from the API in PR openshift/api#540 This will have to land before this can be merged.

Comment on lines +34 to +39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are optional, please add omitempty for json tag. also provide details on the default when not explicitly specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry need to straighten all these out. It's actually not optional even :).

Create a new baremetal deployment CRD containing all the elements needed
to configure the baremetal deployment.
@openshift-ci-robot
Copy link
Contributor

@imain: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-vendor 7379b1e link /test verify-vendor
ci/prow/unit 7379b1e link /test unit
ci/prow/e2e-aws-fips 7379b1e link /test e2e-aws-fips
ci/prow/e2e-libvirt 7379b1e link /test e2e-libvirt
ci/prow/e2e-openstack 7379b1e link /test e2e-openstack
ci/prow/e2e-aws 7379b1e link /test e2e-aws
ci/prow/e2e-aws-upgrade 7379b1e link /test e2e-aws-upgrade
ci/prow/images 7379b1e link /test images
ci/prow/e2e-aws-scaleup-rhel7 7379b1e link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@imain imain closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants