Bug 1783973: Rename rhcos-downloader to machine-os-downloader #2821

elfosardo · 2019-12-16T13:43:07Z

No description provided.

elfosardo · 2019-12-16T14:03:28Z

/retest

elfosardo · 2019-12-16T14:34:10Z

/retest

elfosardo · 2019-12-16T15:30:00Z

/retest

elfosardo · 2019-12-16T16:16:47Z

/retest

wking · 2019-12-17T03:47:06Z

/retitle Bug 1783973: Rename rhcos-downloader to machine-os-downloader

No idea how we're going to ratchet these changes in...

openshift-ci-robot · 2019-12-17T03:47:11Z

@elfosardo: This pull request references Bugzilla bug 1783973, which is valid.

Details

In response to this:

Bug 1783973: Rename rhcos-downloader to machine-os-downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template

wking · 2019-12-17T03:55:20Z

/cherrypick release-4.3

openshift-cherrypick-robot · 2019-12-17T03:55:21Z

@wking: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2019-12-17T14:55:55Z

/label platform/baremetal

metal3ci · 2019-12-17T17:58:15Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1377/

stbenjam

This looks good to me, but please update commit message to include baremetal: prefix

stbenjam

My local test looks good along with openshift-metal3/dev-scripts#866:

level=debug msg="OpenShift console route is created"
level=info msg="Install complete!"

Just the one nit about the commit message, if you want to fix it then @hardys can lgtm and hopefully get this landed ASAP.

stbenjam · 2019-12-18T01:51:41Z

/approve

openshift-ci-robot · 2019-12-18T01:51:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~data/data/bootstrap/baremetal/OWNERS~~ [stbenjam]
~~pkg/asset/machines/baremetal/OWNERS~~ [stbenjam]
~~pkg/tfvars/baremetal/OWNERS~~ [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stbenjam · 2019-12-18T02:04:46Z

/retest

stbenjam · 2019-12-18T05:08:12Z

/retest

metal3ci · 2019-12-18T09:22:30Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1383/

hardys · 2019-12-18T09:22:46Z

/retest

elfosardo · 2019-12-18T10:35:45Z

/retest

wking · 2019-12-18T10:38:36Z

Last images hit a CI-cluster flake:

error: error pulling image docker-registry.default.svc:5000/ci-op-ngcdfplk/pipeline@sha256:e081b21dc1a5cae59398e3846bc9b7fea7794223313df29654f9494c4fbba32f: Get https://docker-registry.default.svc:5000/v2/: dial tcp 172.30.113.112:5000: connect: no route to host

/retest

metal3ci · 2019-12-18T11:12:11Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1384/

wking · 2019-12-18T11:37:15Z

/lgtm

openshift-bot · 2019-12-18T11:41:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-18T11:54:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-18T12:07:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-18T12:20:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2019-12-18T12:49:26Z

Previous e2e-aws died on the unrelated rhbz#1784822.

wking · 2019-12-18T13:09:18Z

/cherrypick release-4.2

openshift-cherrypick-robot · 2019-12-18T13:09:19Z

@wking: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-12-18T13:37:36Z

This e2e-aws is dying with:

Failing tests:

[Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel]
[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]
[Feature:Platform] Service Catalog should check basic usages: OCP-24062, OCP-24049, OCP-15600 [Suite:openshift/conformance/parallel]

That's rhbz#1784822, rhbz#1784837, and some API-server crashlooping pods. All unrelated. Hopefully we sneak in with the next round of retests.

wking · 2019-12-18T13:39:36Z

...some API-server crashlooping pods...

Ah, these are ContainerStatusUnknown: container could not be located when the pod was terminated.

openshift-bot · 2019-12-18T13:51:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-18T15:22:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-18T17:32:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2019-12-18T17:37:14Z

Still banging our heads against rhbz#1734524 and rhbz#1784334. openshift/origin#24323 should help once it lands.

openshift-ci-robot · 2019-12-18T19:14:58Z

@elfosardo: All pull requests linked via external trackers have merged. Bugzilla bug 1783973 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1783973: Rename rhcos-downloader to machine-os-downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-12-18T19:16:05Z

@wking: new pull request created: #2846

Details

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-12-18T19:16:30Z

@wking: #2821 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/asset/machines/baremetal/machines.go
M	pkg/tfvars/baremetal/baremetal.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/tfvars/baremetal/baremetal.go
CONFLICT (content): Merge conflict in pkg/tfvars/baremetal/baremetal.go
Auto-merging pkg/asset/machines/baremetal/machines.go
CONFLICT (content): Merge conflict in pkg/asset/machines/baremetal/machines.go
Patch failed at 0001 baremetal: rename rhcos-downloader to machine-os-downloader

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2019-12-18T19:27:35Z

^failed to apply to 4.2 is fine.

openshift-ci-robot requested review from celebdor and hardys December 16, 2019 13:43

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2019

openshift-ci-robot changed the title ~~Rename rhcos-downloader to machine-os-downloader~~ Bug 1783973: Rename rhcos-downloader to machine-os-downloader Dec 17, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 17, 2019

wking reviewed Dec 17, 2019

View reviewed changes

data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template Outdated Show resolved Hide resolved

elfosardo force-pushed the rename-rhcos branch from 5efdcb5 to 8cdc5f3 Compare December 17, 2019 08:29

elfosardo requested a review from wking December 17, 2019 08:30

openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Dec 17, 2019

stbenjam requested changes Dec 18, 2019

View reviewed changes

stbenjam mentioned this pull request Dec 18, 2019

Rename RHCOS to Machine OS openshift-metal3/dev-scripts#866

Merged

stbenjam approved these changes Dec 18, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019

baremetal: rename rhcos-downloader to machine-os-downloader

849210e

elfosardo force-pushed the rename-rhcos branch from 8cdc5f3 to 849210e Compare December 18, 2019 09:06

openshift-ci-robot assigned wking Dec 18, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019

openshift-merge-robot merged commit 6dd2ccc into openshift:master Dec 18, 2019

openshift-cherrypick-robot mentioned this pull request Dec 18, 2019

Bug 1783974: Rename rhcos-downloader to machine-os-downloader #2846

Merged

Bug 1783973: Rename rhcos-downloader to machine-os-downloader #2821

Bug 1783973: Rename rhcos-downloader to machine-os-downloader #2821

Uh oh!

Conversation

elfosardo commented Dec 16, 2019

Uh oh!

elfosardo commented Dec 16, 2019

Uh oh!

elfosardo commented Dec 16, 2019

Uh oh!

elfosardo commented Dec 16, 2019

Uh oh!

elfosardo commented Dec 16, 2019

Uh oh!

wking commented Dec 17, 2019

Uh oh!

openshift-ci-robot commented Dec 17, 2019

Uh oh!

Uh oh!

wking commented Dec 17, 2019

Uh oh!

openshift-cherrypick-robot commented Dec 17, 2019

Uh oh!

hardys commented Dec 17, 2019

Uh oh!

metal3ci commented Dec 17, 2019

Uh oh!

stbenjam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stbenjam left a comment

Choose a reason for hiding this comment

Uh oh!

stbenjam commented Dec 18, 2019

Uh oh!

openshift-ci-robot commented Dec 18, 2019

Uh oh!

stbenjam commented Dec 18, 2019

Uh oh!

stbenjam commented Dec 18, 2019

Uh oh!

metal3ci commented Dec 18, 2019

Uh oh!

hardys commented Dec 18, 2019

Uh oh!

elfosardo commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

metal3ci commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

openshift-cherrypick-robot commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

openshift-bot commented Dec 18, 2019

Uh oh!

wking commented Dec 18, 2019

Uh oh!

stbenjam left a comment •

edited

Loading