tests/run: Change required IMAGE_PATH to an optional IMAGE_URL on libvirt #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…virt Since 9ee45fb (*: provide a default OS image for libvirt, 2018-09-17, openshift#271), example/libvirt.yaml has a reasonable default. This commit allows the caller to use it instead of needing their own opinion ;). I've also changed _PATH to _URL to allow the caller to point at other remote images, although this means existing callers will have to update (and add an explicit file:// prefix).
openshift-ci-robot
added
size/XS
Contributor
|
Cool. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #271,
example/libvirt.yamlhas a reasonable default. This commit allows the caller to use it instead of needing their own opinion ;).I've also changed
_PATHto_URLto allow the caller to point at other remote images, although this means existing callers will have to update (and add an explicitfile://prefix).CC @crawford, @steveej.