Skip to content

pkg/asset/machines/machineconfig/hyperthreading: Use KernelArguments #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 1 commit into from
Closed

pkg/asset/machines/machineconfig/hyperthreading: Use KernelArguments #2805

wking wants to merge 1 commit into from

Conversation

@wking
Copy link
Member

@wking wking commented Dec 12, 2019

The more-convenient property got vendored in with 5366d28 (#2594) as part of FIPS support.

Docs here.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2019
@wking
pkg/asset/machines/machineconfig/hyperthreading: Use KernelArguments
ba8b7d1 
The more-convenient property got vendored in with 5366d28 (vendor:
Bump machine-config-operator to latest, 2019-10-30, openshift#2594) as part of
FIPS support.
@cgwalters
Copy link
Member

cgwalters commented Dec 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@wking
Copy link
Member Author

wking commented Dec 12, 2019

aws-fips:

error: could not run steps: step e2e-aws-fips failed: template test cancelled

Probably a CI-cluster flake.

/test e2e-aws-fips

jstuever
jstuever approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jstuever
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever jstuever removed their assignment Jan 13, 2020
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 4, 2020

According to GitHub this needs a rebase but does not have needs rebase label...

/label needs-rebase

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

@patrickdillon: The label(s) /label needs-rebase cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

Details

In response to this:

According to GitHub this needs a rebase but does not have needs rebase label...

/label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 4, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 ba8b7d1 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-openstack ba8b7d1 link /test e2e-openstack
ci/prow/e2e-aws ba8b7d1 link /test e2e-aws
ci/prow/yaml-lint ba8b7d1 link /test yaml-lint
ci/prow/tf-lint ba8b7d1 link /test tf-lint
ci/prow/shellcheck ba8b7d1 link /test shellcheck
ci/prow/e2e-aws-upgrade ba8b7d1 link /test e2e-aws-upgrade
ci/prow/unit ba8b7d1 link /test unit
ci/prow/verify-vendor ba8b7d1 link /test verify-vendor
ci/prow/images ba8b7d1 link /test images
ci/prow/golint ba8b7d1 link /test golint
ci/prow/gofmt ba8b7d1 link /test gofmt
ci/prow/govet ba8b7d1 link /test govet
ci/prow/verify-codegen ba8b7d1 link /test verify-codegen
ci/prow/e2e-aws-workers-rhel7 ba8b7d1 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cgwalters added a commit to cgwalters/installer that referenced this pull request Sep 3, 2020
@cgwalters
machineconfig: Use nosmt KernelArgument now
0f18ebe 
This replaces openshift#2805

Eventually it'd be nice to drop the deprecated `/etc/pivot/`
stuff from the MCO, this is a step towards that.
@cgwalters cgwalters mentioned this pull request Sep 3, 2020
Closed
@cgwalters
Copy link
Member

cgwalters commented Sep 3, 2020

I came across this PR again because I was looking at things I was assigned to. Took an opportunity to rebase it on master:
#4138
/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 3, 2020

@cgwalters: Closed this PR.

Details

In response to this:

I came across this PR again because I was looking at things I was assigned to. Took an opportunity to rebase it on master:
#4138
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever jstuever approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@cgwalters cgwalters

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @cgwalters @openshift-ci-robot @patrickdillon @jstuever