Skip to content

WORKSPACE: Get back to bazelbuild/rules_go releases#28

Merged
squat merged 1 commit intoopenshift:masterfrom
wking:bazel-rules-dep
Jul 9, 2018
Merged

WORKSPACE: Get back to bazelbuild/rules_go releases#28
squat merged 1 commit intoopenshift:masterfrom
wking:bazel-rules-dep

Conversation

@wking
Copy link
Member

@wking wking commented Jul 6, 2018

The most recent issue was bazel-contrib/rules_go#1393, which landed on March 21st. That code went out with rules_go v0.11.0:

rules_go$ git log --oneline -1 361556b
361556b Add go_binary out attribute for custom file names (#1393)
rules_go$ git describe --contains 361556b
0.11.0~26

I'm bumping to 0.12.1 as the most-recent tagged release (although 0.13.0 was cut two days ago, and seems to just be missing a tag).

@coreosbot
Copy link

Can one of the admins verify this patch?

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2018
@wking wking force-pushed the bazel-rules-dep branch from b40f4d4 to fc3e2a8 Compare July 6, 2018 21:23
The most recent issue was bazel-contrib/rules_go#1393, which landed on
March 21st [1].  That code went out with rules_go v0.11.0:

  rules_go$ git log --oneline -1 361556b
  361556b Add go_binary out attribute for custom file names (openshift#1393)
  rules_go$ git describe --contains 361556b
  0.11.0~26

I'm bumping to 0.12.1 as the most-recent tagged release [2] (although
0.13.0 was cut two days ago, and seems to just be missing a tag [3]).

While I'm at it, I've bumped bazel-gazelle to it's most-recent tagged
release [4].  I'm not sure if the Bazel libraries are compatible
between minor releases, but they seem to be versioned together so
having 0.12.x versions of both seemed safest.

[1]: bazel-contrib/rules_go#1393 (comment)
[2]: https://github.com/bazelbuild/rules_go/releases
[3]: bazel-contrib/rules_go#1584 (comment)
[4]: https://github.com/bazelbuild/bazel-gazelle/releases
@squat
Copy link
Contributor

squat commented Jul 6, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2018
@squat
Copy link
Contributor

squat commented Jul 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2018
@squat squat merged commit 12332eb into openshift:master Jul 9, 2018
@wking wking deleted the bazel-rules-dep branch July 9, 2018 08:13
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Apr 30, 2019
Seed the random number generator
mkumatag pushed a commit to mkumatag/installer that referenced this pull request Jul 28, 2021
Use the different providers for vpc and powervs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants