pkg/types/installconfig: Fix 'tags' -> 'userTags' JSON serialization #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd missed this while rerolling 89f05da (pkg/types/installconfig: Add AWSPlatform.UserTags, 2018-09-12, openshift#239). I've also updated the UserTags comment to use "for the cluster" instead of "by the cluster". Resources can be created by the installer (not part of the cluster) or by operators living inside the cluster, but regardless of the creator, these cluster resources should get UserTags.
openshift-ci-robot
added
size/XS
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test tf-fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd missed this while rerolling 89f05da (#239).
I've also updated the UserTags comment to use "for the cluster" instead of "by the cluster". Resources can be created by the installer (not part of the cluster) or by operators living inside the cluster, but regardless of the creator, these cluster resources should get
UserTags.Spun off from #236.