Revert "hack/tf-fmt: Add a workaround for origin/release's hardcoding v0.11.7" #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/hold
… v0.11.7" This reverts commit 856350d, openshift#218. openshift/release@bbb02d36 (Bump Terraform from 0.11.7 to 0.11.8, 2018-09-14, openshift/release#1515) has landed, so we can drop the workaround.
openshift-ci-robot
added
approved
wking
force-pushed
the
drop-alpine-terraform-0.11.7-hack
branch
from
ed737aa to
4e9612d
Compare
Member
Author
|
/test tf-fmt |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel openshift/release#1515 landed. |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 856350d, #218.
Once openshift/release#1515 lands, we can drop the workaround.
/hold