-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Azure: document custom VNets & cluster isolation #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: document custom VNets & cluster isolation #2573
Conversation
docs/user/azure/customization.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhixson74 can you provide an example of install-config.yaml for byo-vnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhixson74 can you provide an example of install-config.yaml for byo-vnet.
updated based on this: #2521 (comment)
Add documents for new install-config fields for BYO vnets. Document cluster isolation.
6331c7a to
da09a48
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add documents for new install-config fields for BYO vnets. Document cluster isolation.
JIRA: CORS-1209
Regarding cluster isolation, I assume this level of documentation is sufficient. If we were to document how cluster isolation should be performed manually that would be through official docs channels.
I left out details about what is required when supplying subnets because Azure validation is pending. I assume all of these resources need to be in the specified resourceGroup, but that is also probably somewhat self-evident, beyond that I'm not certain, but could definitely dig in if that should be added to this PR.