Bug 1765308: pkg/types/aws/validation/platform: Include eu-north-1 #2568
Conversation
RHCOS grew support for this in 905db73 (data/data/rhcos.json: update the bootimage to 420.8.20190708.2 for CRI-O 1.14, 2019-07-03, openshift#1941). And until we get something like [1], we need this not-very-DRY bump to keep up. [1]: openshift#1528
The region was added on 2019-07-29 [1] and the canonical ID is
me-south-1 [2]. This fixes:
$ cd platformtests/aws
$ AWS_PROFILE=openshift-dev go test .
--- FAIL: TestGetDefaultInstanceClass (71.40s)
--- FAIL: TestGetDefaultInstanceClass/Middle_East_(Bahrain) (0.00s)
default_instance_class_test.go:99: not a recognized region
FAIL
FAIL github.com/openshift/installer/platformtests/aws 71.420s
And as a new region without m4 support, we need to set its default to
m5 to avoid:
$ AWS_PROFILE=openshift-dev go test .
--- FAIL: TestGetDefaultInstanceClass (75.95s)
--- FAIL: TestGetDefaultInstanceClass/Middle_East_(Bahrain) (1.96s)
default_instance_class_test.go:107: no direct access to region, assuming full support: AuthFailure: AWS was not able to validate the provided access credentials
status code: 401, request id: f05f9e76-2a63-40d1-8748-a67f6d637ba1
default_instance_class_test.go:121: map[m5:{} m5d:{} t3:{}]
default_instance_class_test.go:122:
Error Trace:default_instance_class_test.go:122
Error: Not equal:
expected: "m4"
actual : "m5"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-m4
+m5
Test: TestGetDefaultInstanceClass/Middle_East_(Bahrain)
FAIL
FAIL github.com/openshift/installer/platformtests/aws75.965s
[1]: https://aws.amazon.com/about-aws/whats-new/2019/07/announcing-the-new-aws-middle-east--bahrain--region-/
[2]: aws/aws-sdk-go@384f453#diff-fe3b36d57dc4378fa7b13c85492f4119R49
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retitle Bug 1765269: pkg/types/aws/validation/platform: Include eu-north-1 |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1765269, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/retitle Bug 1765308: pkg/types/aws/validation/platform: Include eu-north-1 |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1765308, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Yeah, I think we should just consider them on a case by case basis. In this case the RHCOS image was already available in that region since 4.2 GA and the only thing missing is the installer change. Also, the things those bugs say we're going to focus on making happen back in July still haven't come to fruition. 😺 Do you have any concerns about supporting 4.2 in eu-north-1? ie: instance types missing, zones < 3 ? Looks like it's a 3 AZ region. /bugzilla refresh |
|
@sdodson: This pull request references Bugzilla bug 1765308, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
No concerns. But I also don't have concerns about supporting ap-east-1 in 4.1.z, and we still don't ;). /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
eparis
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1765308 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This is an automated cherry-pick of #2308
/assign sdodson