Enable user defined default ingresscontroller #2523
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
ironcladlou
force-pushed
the
default-ingress-controller
branch
from
4e271fe to
a9a2a1c
Compare
openshift-ci-robot
added
size/S
ironcladlou
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Depends on openshift/cluster-ingress-operator#309. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@abhinavdahiya for the first revision I've pared it down to the absolute minimum required. The next followup can be integration with the publishing strategy from #2521. |
|
@abhinavdahiya openshift/cluster-ingress-operator#309 merged, this is ready for review. /retest |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Would you mind including in the commit of the PR body, the output of the render command on the bootstrap-host. |
|
/test e2e-gcp /test e2e-azure /test e2e-aws-upi |
Render ingress operator manifests during bootstrap. This enables users to bring their own default ingresscontroller resource by using `openshift-install create manifests` and placing ingresscontroller YAML into the `manifests/` directory. At the time of this commit, the rendered output on the bootstrap node will be the ingressoperator CRD[1] and namespace[2]. This is the first part of the "User Defined Default Ingress Controller" enhancement proposal[3]. [1] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-custom-resource-definition-internal.yaml [2] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-namespace.yaml [3] https://github.com/openshift/enhancements/blob/master/enhancements/user-defined-default-ingress-controller.md
ironcladlou
force-pushed
the
default-ingress-controller
branch
from
a9a2a1c to
13adb6b
Compare
I added some links instead, because the contents are huge and should be opaque to the installer anyway. |
|
/test e2e-gcp /test e2e-azure /test e2e-aws-upi |
/approve |
openshift-ci-robot
added
the
approved
|
@abhinavdahiya can I get a lgtm on this? |
|
@ironcladlou waiting for some optional platform specific PRs to go green enough and i'll drop an lgtm then. |
|
/test e2e-metal |
|
/test e2e-aws-upi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ironcladlou: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Render ingress operator manifests during bootstrap. This enables users to bring
their own default ingresscontroller resource by using
openshift-install create manifestsand placing ingresscontroller YAML into themanifests/directory.At the time of this commit, the rendered output on the bootstrap node will be
the ingressoperator CRD[1] and namespace[2].
This is the first part of the "User Defined Default Ingress Controller"
enhancement proposal[3].
[1] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-custom-resource-definition-internal.yaml
[2] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-namespace.yaml
[3] https://github.com/openshift/enhancements/blob/master/enhancements/user-defined-default-ingress-controller.md
TODO: