Skip to content

data/aws/vpc: Add an elasticloadbalancing endpoint #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 2 commits into from
Closed

data/aws/vpc: Add an elasticloadbalancing endpoint #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b533966
data/aws/vpc: Add an elasticloadbalancing endpoint
wking Oct 9, 2019
1bc4717
docs/user/aws/images/install_upi: Add the ELB VPC endpoint
wking Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions data/data/aws/vpc/vpc.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,17 @@ resource "aws_vpc" "new_vpc" {
)
}

resource "aws_vpc_endpoint" "elasticloadbalancing" {
Copy link
Contributor

@abhinavdahiya abhinavdahiya Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i don't think we should be creating these endpoints in IPI as they don't provide great value to the cluster.

If they do, let's start a general discussion about these elsewhere, github issue / enhacements.

count = var.vpc == null ? 1 : 0

vpc_id = data.aws_vpc.cluster_vpc.id
service_name = "com.amazonaws.${var.region}.elasticloadbalancing"
route_table_ids = concat(
aws_route_table.private_routes.*.id,
aws_route_table.default.*.id,
)
}

resource "aws_vpc_endpoint" "s3" {
count = var.vpc == null ? 1 : 0

Expand Down
Binary file modified docs/user/aws/images/install_upi.dia
View file
Open in desktop
Binary file not shown.
18 changes: 15 additions & 3 deletions docs/user/aws/images/install_upi.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 7 additions & 3 deletions docs/user/aws/images/install_upi_vpc.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions upi/aws/cloudformation/01_vpc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,29 @@ Resources:
DestinationCidrBlock: 0.0.0.0/0
NatGatewayId:
Ref: NAT3
LoadBalancingEndpoint:
Copy link
Contributor

@abhinavdahiya abhinavdahiya Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this UPI templates are reference only. And I don't think we allow special env setup to handle these and not add these for all.

This is not required for openshift clusters and don't provide value.

Type: AWS::EC2::VPCEndpoint
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Principal: '*'
Action:
- '*'
Resource:
- '*'
RouteTableIds:
- !Ref PublicRouteTable
- !Ref PrivateRouteTable
- !If [DoAz2, !Ref PrivateRouteTable2, !Ref "AWS::NoValue"]
- !If [DoAz3, !Ref PrivateRouteTable3, !Ref "AWS::NoValue"]
ServiceName: !Join
- ''
- - com.amazonaws.
- !Ref 'AWS::Region'
- .elasticloadbalancing
VpcId: !Ref VPC
S3Endpoint:
Type: AWS::EC2::VPCEndpoint
Properties:
Expand Down