Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 8, 2019

Since 82d81d9 (#2086), we've been pushing the OpenShift-specific components via a loopback kubeconfig and the bootstrap control plane. Since 108a45b (#1381), that push has always happened before the bootstrap control plane shuts down.

I've changed "into" to "via" because the data passes through either control plane on its way to rest in the shared etcd cluster.

I've dropped "then" from the final step because none of the other steps said "then". I think ordering is clear enough from our use of an ordered list ;).

…ntrol-plane teardown

Since 82d81d9 (data/data/bootstrap: use loopback kubeconfig for API
access, 2019-07-24, openshift#2086), we've been pushing the OpenShift-specific
components via a loopback kubeconfig and the bootstrap control plane.
Since 108a45b (data/bootstrap: Replace openshift.sh with
cluster-bootstrap, 2019-01-24, landed 2019-09-30, openshift#1381), that push
has always happened before the bootstrap control plane shuts down.

I've changed "into" to "via" because the data passes through either
control plane on its way to rest in the shared etcd cluster.

I've dropped "then" from the final step because none of the other
steps said "then".  I think ordering is clear enough from our use of
an ordered list ;).
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2019
@wking
Copy link
Member Author

wking commented Oct 8, 2019

CC @kalexand-rh, since this will need an upstream port to openshift-docs' 4.2 branch once it lands here.

@abhinavdahiya
Copy link
Contributor

/approve

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b1d8acb into openshift:master Oct 9, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 109c0cb link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the docs-drop-openshift-specific-components branch October 10, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants