Documentation/design/installconfig: Drop this file

[wking]

Now that these structures are defined under pkg/type/, dropping this file avoids either the content going stale (if we don't keep it up to date) or tedious updates (if we do keep it up to date). Consumers who want details on the structure can use the godocs.

[abhinavdahiya]

nit: As a lot of operator teams will be depending on this struct, we will very often be sharing a link to InstallConfig so maybe add this link https://godoc.org/github.com/openshift/installer/pkg/types#InstallConfig as comment. It will be easier to directly copy from there when needed.

Otherwise i'm okay with dropping if keeping it in sync is a problem.
/cc @crawford

[crawford]

I'd rather generate docs from code than try to keep things up-to-date by hand.

/approve

[wking]

... so maybe add this link https://godoc.org/github.com/openshift/installer/pkg/types#InstallConfig as comment.

You mean beyond the the godocs link in my initial PR comment? Or somewhere in the Git repo itself (somewhere (new?) under Documentation/?)? Maybe in the README and libvirt howto?

[abhinavdahiya]

You mean beyond the the godocs link in my initial PR comment? Or somewhere in the Git repo itself

README sounds good?

[wking]

README sounds good?

Done with 5d661f0 -> 9ac6e0d.

[abhinavdahiya]

/lgtm

[wking]

Rebased around #237 with 9ac6e0d -> d006d8c.

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment