Bug 1752135: data/aws: Set 20m creation timeouts for instances #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been hitting the default 10m timeout recently, starting around [1]. Use the creation timeout knob [2] to wait a bit longer before giving up on AWS. 20m matches the value we've used bumping this timeout for other resources in 1ec2758 (data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m, 2019-08-27, openshift#2279) and previous. There's no guarantee that 20m will be sufficient, the issue could be due to internal AWS issues like a shortage of on-demand instances of the requested type in the requested availability zone. But it gives AWS an even easier target to hit ;). [1]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_console/2708/pull-ci-openshift-console-master-e2e-aws-console-olm/8584 [2]: https://www.terraform.io/docs/providers/aws/r/instance.html#timeouts
openshift-ci-robot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Member
Author
|
/retitle Bug 1752135: data/aws: Set 20m creation timeouts for instances |
openshift-ci-robot
changed the title
Member
|
/close |
Contributor
|
@sdodson: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been hitting the default 10m timeout recently, starting around here. Use the creation timeout knob to wait a bit longer before giving up on AWS. 20m matches the value we've used bumping this timeout for other resources in 1ec2758 (#2279) and previous. There's no guarantee that 20m will be sufficient, the issue could be due to internal AWS issues like a shortage of on-demand instances of the requested type in the requested availability zone. But it gives AWS an even easier target to hit ;).